Disabling caching for the repository clone view

Author: StanleyGoldman

src/GitHub.App/SampleData/Dialog/Clone/SelectPageViewModelDesigner.cs

@@ -41,7 +41,6 @@ public SelectPageViewModelDesigner()
         public ICollectionView ItemsView { get; }
         public IRepositoryItemViewModel SelectedItem { get; set; }
         public RepositoryModel Repository { get; }
-        public ReactiveCommand<Unit, Unit> Refresh { get; }
 
         public void Initialize(IConnection connection)
         {

src/GitHub.App/ViewModels/Dialog/Clone/RepositorySelectViewModel.cs

@@ -35,7 +35,6 @@ public class RepositorySelectViewModel : ViewModelBase, IRepositorySelectViewMod
         ICollectionView itemsView;
         ObservableAsPropertyHelper<RepositoryModel> repository;
         IRepositoryItemViewModel selectedItem;
-        static bool firstLoad = true;
 
         [ImportingConstructor]
         public RepositorySelectViewModel(IRepositoryCloneService service, IGitHubContextService gitHubContextService)
@@ -58,12 +57,6 @@ public RepositorySelectViewModel(IRepositoryCloneService service, IGitHubContext
                 .ToProperty(this, x => x.Repository);
 
             this.WhenAnyValue(x => x.Filter).Subscribe(_ => ItemsView?.Refresh());
-
-            Refresh = ReactiveCommand.CreateFromTask(async () =>
-            {
-                await this.LoadItems(true);
-                return Unit.Default;
-            });
         }
 
         public Exception Error
@@ -108,8 +101,6 @@ public IRepositoryItemViewModel SelectedItem
             set => this.RaiseAndSetIfChanged(ref selectedItem, value);
         }
 
-        public ReactiveCommand<Unit, Unit> Refresh { get; }
-
         public RepositoryModel Repository => repository.Value;
 
         public void Initialize(IConnection connection)
@@ -122,8 +113,7 @@ public void Initialize(IConnection connection)
 
         public async Task Activate()
         {
-            await this.LoadItems(firstLoad);
-            firstLoad = false;
+            await this.LoadItems(true);
         }
 
         static string GroupName(KeyValuePair<string, IReadOnlyList<RepositoryListItemModel>> group, int max)

src/GitHub.Exports.Reactive/ViewModels/Dialog/Clone/IRepositorySelectViewModel.cs

@@ -16,7 +16,6 @@ public interface IRepositorySelectViewModel : IRepositoryCloneTabViewModel
         IReadOnlyList<IRepositoryItemViewModel> Items { get; }
         ICollectionView ItemsView { get; }
         IRepositoryItemViewModel SelectedItem { get; set; }
-        ReactiveCommand<Unit, Unit> Refresh { get; }
 
         void Initialize(IConnection connection);
     }

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/SelectPageView.xaml

@@ -21,11 +21,11 @@
     </UserControl.Resources>
 
     <DockPanel>
-        <DockPanel DockPanel.Dock="Top" Margin="0,4">
-            <Button DockPanel.Dock="Right" Command="{Binding Refresh}">Refresh</Button>
-            <ghfvs:PromptTextBox PromptText="Search or enter a URL"
-                                 Text="{Binding Filter, UpdateSourceTrigger=PropertyChanged, Delay=300}"/>
-        </DockPanel>
+        <ghfvs:PromptTextBox DockPanel.Dock="Top"
+                             Margin="0,4"
+                             PromptText="Search or enter a URL"
+                             Text="{Binding Filter, UpdateSourceTrigger=PropertyChanged, Delay=300}"/>
+
         <Grid>
             <ListView BorderThickness="0"
                       ItemsSource="{Binding ItemsView}"