Merge pull request #1673 from github/fixes/1654-pr-authoring-link

jcansdale · web-flow · commit d2f9564580e6 · 2018-05-16T21:44:39.000+01:00
Make PR# link work in authoring view.
diff --git a/src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewAuthoringViewModel.cs b/src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewAuthoringViewModel.cs
@@ -12,6 +12,7 @@
 using GitHub.Services;
 using ReactiveUI;
 using Serilog;
+using static System.FormattableString;
 
 namespace GitHub.ViewModels.GitHubPane
 {
@@ -71,6 +72,8 @@ public PullRequestReviewAuthoringViewModel(
                 hasBodyOrComments,
                 _ => DoSubmit(Octokit.PullRequestReviewEvent.RequestChanges));
             Cancel = ReactiveCommand.CreateAsyncTask(DoCancel);
+            NavigateToPullRequest = ReactiveCommand.Create().OnExecuteCompleted(_ =>
+                NavigateTo(Invariant($"{LocalRepository.Owner}/{LocalRepository.Name}/pull/{PullRequestModel.Number}")));
         }
 
         /// <inheritdoc/>

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`using GitHub.Services;`
`13`	`13`	`using ReactiveUI;`
`14`	`14`	`using Serilog;`
	`15`	`+using static System.FormattableString;`
`15`	`16`
`16`	`17`	`namespace GitHub.ViewModels.GitHubPane`
`17`	`18`	`{`
`@@ -71,6 +72,8 @@ public PullRequestReviewAuthoringViewModel(`
`71`	`72`	`hasBodyOrComments,`
`72`	`73`	`_ => DoSubmit(Octokit.PullRequestReviewEvent.RequestChanges));`
`73`	`74`	`Cancel = ReactiveCommand.CreateAsyncTask(DoCancel);`
	`75`	`+ NavigateToPullRequest = ReactiveCommand.Create().OnExecuteCompleted(_ =>`
	`76`	`+ NavigateTo(Invariant($"{LocalRepository.Owner}/{LocalRepository.Name}/pull/{PullRequestModel.Number}")));`
`74`	`77`	`}`
`75`	`78`
`76`	`79`	`/// <inheritdoc/>`