Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 7c789ae

Browse files
committed
Merge branch 'refactor/pullrequestfilesviewmodel' into feature/pr-details-review-list
2 parents 8b6a424 + b203545 commit 7c789ae

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

src/GitHub.App/GitHub.App.csproj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,14 @@
147147
<Reference Include="Microsoft.VisualStudio.Utilities, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
148148
<HintPath>..\..\packages\Microsoft.VisualStudio.Utilities.14.3.25407\lib\net45\Microsoft.VisualStudio.Utilities.dll</HintPath>
149149
<Private>True</Private>
150+
<Reference Include="Microsoft.VisualStudio.Utilities, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
151+
<HintPath>..\..\packages\Microsoft.VisualStudio.Utilities.14.3.25407\lib\net45\Microsoft.VisualStudio.Utilities.dll</HintPath>
152+
<Private>True</Private>
153+
</Reference>
154+
<Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
155+
<SpecificVersion>False</SpecificVersion>
156+
<HintPath>..\..\packages\Newtonsoft.Json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath>
157+
<Private>False</Private>
150158
</Reference>
151159
<Reference Include="PresentationCore" />
152160
<Reference Include="PresentationFramework" />

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestFilesView.xaml

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,23 @@
22
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
33
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
44
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
5-
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
6-
xmlns:cache="clr-namespace:GitHub.UI.Helpers;assembly=GitHub.UI"
7-
xmlns:ui="clr-namespace:GitHub.UI;assembly=GitHub.UI"
8-
xmlns:vm="clr-namespace:GitHub.ViewModels.GitHubPane;assembly=GitHub.App"
5+
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
6+
xmlns:ghfvs="https://github.com/github/VisualStudio"
97
xmlns:prop="clr-namespace:GitHub.VisualStudio.UI;assembly=GitHub.VisualStudio.UI"
10-
xmlns:sample="clr-namespace:GitHub.SampleData;assembly=GitHub.App"
118
mc:Ignorable="d" d:DesignHeight="300" d:DesignWidth="300"
129
Name="root">
1310

1411
<d:DesignProperties.DataContext>
15-
<sample:PullRequestFilesViewModelDesigner/>
12+
<ghfvs:PullRequestFilesViewModelDesigner/>
1613
</d:DesignProperties.DataContext>
1714

1815
<Control.Resources>
1916
<ResourceDictionary>
2017
<ResourceDictionary.MergedDictionaries>
21-
<cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.VisualStudio.UI;component/SharedDictionary.xaml" />
22-
<cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/SharedDictionary.xaml" />
23-
<cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI.Reactive;component/SharedDictionary.xaml" />
24-
<cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/Assets/Markdown.xaml" />
18+
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.VisualStudio.UI;component/SharedDictionary.xaml" />
19+
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/SharedDictionary.xaml" />
20+
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI.Reactive;component/SharedDictionary.xaml" />
21+
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/Assets/Markdown.xaml" />
2522
</ResourceDictionary.MergedDictionaries>
2623

2724
<ContextMenu x:Key="FileContextMenu">
@@ -46,19 +43,18 @@
4643
<TreeView.ItemContainerStyle>
4744
<Style TargetType="TreeViewItem">
4845
<Setter Property="IsExpanded" Value="True"/>
49-
<Setter Property="Foreground" Value="{DynamicResource GitHubVsWindowText}"/>
5046
</Style>
5147
</TreeView.ItemContainerStyle>
5248
<TreeView.Resources>
53-
<HierarchicalDataTemplate DataType="{x:Type vm:PullRequestDirectoryNode}"
49+
<HierarchicalDataTemplate DataType="{x:Type ghfvs:PullRequestDirectoryNode}"
5450
ItemsSource="{Binding Children}">
5551
<StackPanel Orientation="Horizontal">
56-
<ui:OcticonImage Icon="file_directory" Foreground="{DynamicResource GitHubDirectoryIconForeground}" Margin="0,0,0,2"/>
52+
<ghfvs:OcticonImage Icon="file_directory" Foreground="{DynamicResource GitHubDirectoryIconForeground}" Margin="0,0,0,2"/>
5753
<TextBlock Text="{Binding DirectoryName}" Margin="4 2" VerticalAlignment="Center"/>
5854
</StackPanel>
5955
</HierarchicalDataTemplate>
6056

61-
<DataTemplate DataType="{x:Type vm:PullRequestFileNode}">
57+
<DataTemplate DataType="{x:Type ghfvs:PullRequestFileNode}">
6258
<StackPanel Orientation="Horizontal"
6359
Tag="{Binding DataContext, ElementName=root}"
6460
KeyboardNavigation.DirectionalNavigation="None">
@@ -82,7 +78,7 @@
8278
</Style.Triggers>
8379
</Style>
8480
</Decorator.Style>
85-
<ui:OcticonImage Icon="file_code" Margin="0,0,0,2"/>
81+
<ghfvs:OcticonImage Icon="file_code" Margin="0,0,0,2"/>
8682
</Decorator>
8783

8884
<TextBlock Text="{Binding FileName}" Margin="4 2" VerticalAlignment="Center">
@@ -126,7 +122,7 @@
126122
</Style.Triggers>
127123
</Style>
128124
</TextBlock.Style>
129-
<ui:OcticonImage Icon="comment_discussion" Height="10" Margin="-2 0"/>
125+
<ghfvs:OcticonImage Icon="comment_discussion" Height="10" Margin="-2 0"/>
130126
<Hyperlink Command="{Binding DataContext.OpenFirstComment, ElementName=root}"
131127
CommandParameter="{Binding}">
132128
<Run Text="{Binding CommentCount, Mode=OneWay}"/>

0 commit comments

Comments
 (0)