Don't show other users' pending reviews.

Author: grokys

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

@@ -369,7 +369,7 @@ public async Task Load(IPullRequestModel pullRequest)
                 TargetBranchDisplayName = GetBranchDisplayName(IsFromFork, pullRequest.Base?.Label);
                 CommentCount = pullRequest.Comments.Count + pullRequest.ReviewComments.Count;
                 Body = !string.IsNullOrWhiteSpace(pullRequest.Body) ? pullRequest.Body : Resources.NoDescriptionProvidedMarkdown;
-                Reviews = PullRequestReviewSummaryViewModel.BuildByUser(pullRequest).ToList();
+                Reviews = PullRequestReviewSummaryViewModel.BuildByUser(Session.User, pullRequest).ToList();
 
                 await Files.InitializeAsync(Session);
 

src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewSummaryViewModel.cs

@@ -29,17 +29,23 @@ public class PullRequestReviewSummaryViewModel : IPullRequestReviewSummaryViewMo
         /// <summary>
         /// Builds a collection of <see cref="PullRequestReviewSummaryViewModel"/>s by user.
         /// </summary>
+        /// <param name="currentUser">The current user.</param>
         /// <param name="pullRequest">The pull request model.</param>
         /// <remarks>
         /// This method builds a list similar to that found in the "Reviewers" section at the top-
         /// right of the Pull Request page on GitHub.
         /// </remarks>
-        public static IEnumerable<PullRequestReviewSummaryViewModel> BuildByUser(IPullRequestModel pullRequest)
+        public static IEnumerable<PullRequestReviewSummaryViewModel> BuildByUser(
+            IAccount currentUser,
+            IPullRequestModel pullRequest)
         {
             var existing = new Dictionary<string, PullRequestReviewSummaryViewModel>();
 
             foreach (var review in pullRequest.Reviews.OrderBy(x => x.Id))
             {
+                if (review.State == PullRequestReviewState.Pending && review.User.Login != currentUser.Login)
+                    continue;
+
                 PullRequestReviewSummaryViewModel previous;
                 existing.TryGetValue(review.User.Login, out previous);
 
@@ -68,6 +74,7 @@ public static IEnumerable<PullRequestReviewSummaryViewModel> BuildByUser(IPullRe
                 var newReview = new PullRequestReviewSummaryViewModel
                 {
                     State = PullRequestReviewState.Pending,
+                    User = currentUser,
                 };
                 result = result.Concat(new[] { newReview });
             }

test/UnitTests/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModelTests.cs

@@ -68,7 +68,7 @@ public async Task ShouldShowLatestAcceptedOrChangesRequestedReview()
                 Assert.That(target.Reviews, Has.Count.EqualTo(3));
                 Assert.That(target.Reviews[0].User.Login, Is.EqualTo("grokys"));
                 Assert.That(target.Reviews[1].User.Login, Is.EqualTo("shana"));
-                Assert.That(target.Reviews[2].User, Is.Null);
+                Assert.That(target.Reviews[2].User.Login, Is.EqualTo("grokys"));
                 Assert.That(target.Reviews[0].Id, Is.EqualTo(3));
                 Assert.That(target.Reviews[1].Id, Is.EqualTo(2));
                 Assert.That(target.Reviews[2].Id, Is.EqualTo(0));
@@ -79,14 +79,14 @@ public async Task ShouldShowLatestCommentedReviewIfNothingElsePresent()
             {
                 var target = CreateTarget();
                 var model = CreatePullRequestModel(
-                    CreatePullRequestReviewModel(1, "grokys", PullRequestReviewState.Commented),
-                    CreatePullRequestReviewModel(2, "grokys", PullRequestReviewState.Commented));
+                    CreatePullRequestReviewModel(1, "shana", PullRequestReviewState.Commented),
+                    CreatePullRequestReviewModel(2, "shana", PullRequestReviewState.Commented));
 
                 await target.Load(model);
 
                 Assert.That(target.Reviews, Has.Count.EqualTo(2));
-                Assert.That(target.Reviews[0].User.Login, Is.EqualTo("grokys"));
-                Assert.That(target.Reviews[1].User, Is.Null);
+                Assert.That(target.Reviews[0].User.Login, Is.EqualTo("shana"));
+                Assert.That(target.Reviews[1].User.Login, Is.EqualTo("grokys"));
                 Assert.That(target.Reviews[0].Id, Is.EqualTo(2));
             }
 
@@ -119,6 +119,20 @@ public async Task ShouldShowPendingReviewOverApproved()
                 Assert.That(target.Reviews[0].Id, Is.EqualTo(2));
             }
 
+            [Test]
+            public async Task ShouldNotShowPendingReviewForOtherUser()
+            {
+                var target = CreateTarget();
+                var model = CreatePullRequestModel(
+                    CreatePullRequestReviewModel(1, "shana", PullRequestReviewState.Pending));
+
+                await target.Load(model);
+
+                Assert.That(target.Reviews, Has.Count.EqualTo(1));
+                Assert.That(target.Reviews[0].User.Login, Is.EqualTo("grokys"));
+                Assert.That(target.Reviews[0].Id, Is.EqualTo(0));
+            }
+
             static PullRequestModel CreatePullRequestModel(
                 params IPullRequestReviewModel[] reviews)
             {
@@ -550,7 +564,7 @@ static Tuple<PullRequestDetailViewModel, IPullRequestService> CreateTargetAndSer
             if (sessionManager == null)
             {
                 var currentSession = Substitute.For<IPullRequestSession>();
-                currentSession.User.Login.Returns("[CurrentUser]");
+                currentSession.User.Login.Returns("grokys");
 
                 sessionManager = Substitute.For<IPullRequestSessionManager>();
                 sessionManager.CurrentSession.Returns(currentSession);