Merge pull request #60 from github/haacked/minor-fixups

🎨 Remove rendundant null check

Author: shana

src/GitHub.App/Controllers/UIController.cs

@@ -272,8 +272,7 @@ protected virtual void Dispose(bool disposing)
 
                 Debug.WriteLine("Disposing ({0})", GetHashCode());
                 disposables.Dispose();
-                if (transition != null)
-                    transition.Dispose();
+                transition?.Dispose();
                 disposed = true;
             }
         }

src/GitHub.App/Models/RepositoryHost.cs

@@ -104,7 +104,7 @@ public IObservable<AuthenticationResult> LogIn(string usernameOrEmail, string pa
             // in multiple places in the chain below:
             var saveAuthorizationToken = new Func<ApplicationAuthorization, IObservable<Unit>>(authorization =>
             {
-                var token = authorization != null ? authorization.Token : null;
+                var token = authorization?.Token;
                 if (string.IsNullOrWhiteSpace(token))
                     return Observable.Return(Unit.Default);
 

src/GitHub.App/Services/AvatarProvider.cs

@@ -67,7 +67,7 @@ public IObservable<BitmapSource> GetAvatar(IAvatarContainer apiAccount)
 
         public IObservable<Unit> InvalidateAvatar([AllowNull] IAvatarContainer apiAccount)
         {
-            return apiAccount == null || String.IsNullOrWhiteSpace(apiAccount.Login)
+            return String.IsNullOrWhiteSpace(apiAccount?.Login)
                 ? Observable.Return(Unit.Default)
                 : cache.Invalidate(apiAccount.Login);
         }

src/GitHub.App/Services/GitClient.cs

@@ -18,10 +18,7 @@ public IObservable<Unit> Push(IRepository repository, string branchName, string
 
             return Observable.Defer(() =>
             {
-                if (repository.Head != null
-                    && repository.Head != null
-                    && repository.Head.Commits != null
-                    && repository.Head.Commits.Any())
+                if (repository.Head?.Commits != null && repository.Head.Commits.Any())
                 {
                     var remote = repository.Network.Remotes[remoteName];
                     repository.Network.Push(remote, "HEAD", @"refs/heads/" + branchName);

src/GitHub.App/Services/Translation.cs

@@ -67,12 +67,9 @@ protected virtual Tuple<Translation, string> Match(Exception exception)
             string exceptionMessage = exception.Message;
 
             var apiException = exception as ApiValidationException;
-            if (apiException != null && apiException.ApiError != null && apiException.ApiError.Errors != null)
-            {
-                var error = apiException.ApiError.Errors.FirstOrDefault();
-                if (error != null)
-                    exceptionMessage = error.Message ?? exceptionMessage;
-            }
+            var error = apiException?.ApiError?.Errors?.FirstOrDefault();
+            if (error != null)
+                exceptionMessage = error.Message ?? exceptionMessage;
 
             if (Original == exceptionMessage) return new Tuple<Translation, string>(this, null);
 

src/GitHub.App/ViewModels/RepositoryPublishViewModel.cs

@@ -191,7 +191,7 @@ void InitializeValidation()
 
             this.WhenAny(x => x.SafeRepositoryNameWarningValidator.ValidationResult, x => x.Value)
                 .WhereNotNull() // When this is instantiated, it sends a null result.
-                .Select(result => result == null ? null : result.Message)
+                .Select(result => result?.Message)
                 .Subscribe(message =>
                 {
                     if (!string.IsNullOrEmpty(message))