Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 50b6102

Browse files
committed
Don't show Connect when Start Page button clicked
There's no more need to explicitly show the Team Explorer - Connect page when the Start Page GitHub button is clicked. This will happen automatically before cloning.
1 parent 61ce000 commit 50b6102

File tree

1 file changed

+0
-32
lines changed

1 file changed

+0
-32
lines changed

src/GitHub.StartPage/StartPagePackage.cs

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System;
2-
using System.ComponentModel;
32
using System.IO;
43
using System.Runtime.InteropServices;
54
using System.Threading;
@@ -9,7 +8,6 @@
98
using GitHub.Primitives;
109
using GitHub.Services;
1110
using GitHub.VisualStudio;
12-
using Microsoft.TeamFoundation.Controls;
1311
using Microsoft.VisualStudio.Shell;
1412
using Microsoft.VisualStudio.Shell.CodeContainerManagement;
1513
using Microsoft.VisualStudio.Threading;
@@ -59,7 +57,6 @@ async Task<CodeContainer> RunAcquisition(IProgress<ServiceProgressData> download
5957
try
6058
{
6159
var uiProvider = await Task.Run(() => Package.GetGlobalService(typeof(IGitHubServiceProvider)) as IGitHubServiceProvider);
62-
await ShowTeamExplorerPage(uiProvider);
6360
request = await ShowCloneDialog(uiProvider, downloadProgress, repository);
6461
}
6562
catch (Exception e)
@@ -84,35 +81,6 @@ async Task<CodeContainer> RunAcquisition(IProgress<ServiceProgressData> download
8481
lastAccessed: DateTimeOffset.UtcNow);
8582
}
8683

87-
async Task ShowTeamExplorerPage(IGitHubServiceProvider gitHubServiceProvider)
88-
{
89-
var te = gitHubServiceProvider?.GetService(typeof(ITeamExplorer)) as ITeamExplorer;
90-
91-
if (te != null)
92-
{
93-
var page = te.NavigateToPage(new Guid(TeamExplorerPageIds.Connect), null);
94-
95-
if (page == null)
96-
{
97-
var tcs = new TaskCompletionSource<ITeamExplorerPage>();
98-
PropertyChangedEventHandler handler = null;
99-
100-
handler = new PropertyChangedEventHandler((s, e) =>
101-
{
102-
if (e.PropertyName == "CurrentPage")
103-
{
104-
tcs.SetResult(te.CurrentPage);
105-
te.PropertyChanged -= handler;
106-
}
107-
});
108-
109-
te.PropertyChanged += handler;
110-
111-
page = await tcs.Task;
112-
}
113-
}
114-
}
115-
11684
async Task<CloneDialogResult> ShowCloneDialog(
11785
IGitHubServiceProvider gitHubServiceProvider,
11886
IProgress<ServiceProgressData> progress,

0 commit comments

Comments
 (0)