Merge pull request #392 from github/fixes/391-trackingcollection-nre

shana · web-flow · commit 4bd67064b8f5 · 2016-07-05T12:08:34.000+02:00
Allow null param to CreateListenerCollection
diff --git a/src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs b/src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs
@@ -15,6 +15,7 @@
 using System.Reactive.Linq;
 using System.Reactive.Subjects;
 using System.Threading;
+using System.Linq;
 
 namespace GitHub.Collections
 {
@@ -46,7 +47,7 @@ public static ObservableCollection<T> CreateListenerCollection<T>(this ITracking
             IList<T> stickieItemsOnTop = null)
             where T : class, ICopyable<T>
         {
-            var col = new ObservableCollection<T>(stickieItemsOnTop);
+            var col = new ObservableCollection<T>(stickieItemsOnTop ?? Enumerable.Empty<T>());
             tcol.CollectionChanged += (s, e) =>
             {
                 var offset = 0;

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`using System.Reactive.Linq;`
`16`	`16`	`using System.Reactive.Subjects;`
`17`	`17`	`using System.Threading;`
	`18`	`+using System.Linq;`
`18`	`19`
`19`	`20`	`namespace GitHub.Collections`
`20`	`21`	`{`
`@@ -46,7 +47,7 @@ public static ObservableCollection<T> CreateListenerCollection<T>(this ITracking`
`46`	`47`	`IList<T> stickieItemsOnTop = null)`
`47`	`48`	`where T : class, ICopyable<T>`
`48`	`49`	`{`
`49`		`- var col = new ObservableCollection<T>(stickieItemsOnTop);`
	`50`	`+ var col = new ObservableCollection<T>(stickieItemsOnTop ?? Enumerable.Empty<T>());`
`50`	`51`	`tcol.CollectionChanged += (s, e) =>`
`51`	`52`	`{`
`52`	`53`	`var offset = 0;`