Merge pull request #379 from github/backport/367-fix-exports-crash

shana · web-flow · commit 40d46500bab2 · 2016-06-22T19:16:20.000+02:00
Handling File I/O crash in GitHub.Exports in master
diff --git a/src/GitHub.Exports/Services/Logger.cs b/src/GitHub.Exports/Services/Logger.cs
@@ -77,7 +77,14 @@ static async void DefaultLogger(string msg)
             await System.Threading.Tasks.Task.Delay(500);
             lock(fileLock)
             {
-                File.AppendAllText(defaultLogPath, msg, Encoding.UTF8);
+                // TODO: Fix this properly
+                try
+                {
+                    File.AppendAllText(defaultLogPath, msg, Encoding.UTF8);
+                }
+                catch(Exception)
+                {
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,14 @@ static async void DefaultLogger(string msg)`
`77`	`77`	`await System.Threading.Tasks.Task.Delay(500);`
`78`	`78`	`lock(fileLock)`
`79`	`79`	`{`
`80`		`- File.AppendAllText(defaultLogPath, msg, Encoding.UTF8);`
	`80`	`+ // TODO: Fix this properly`
	`81`	`+ try`
	`82`	`+ {`
	`83`	`+ File.AppendAllText(defaultLogPath, msg, Encoding.UTF8);`
	`84`	`+ }`
	`85`	`+ catch(Exception)`
	`86`	`+ {`
	`87`	`+ }`
`81`	`88`	`}`
`82`	`89`	`}`
`83`	`90`	`}`