Go back to using full objects when removing

Author: shana

src/GitHub.App/Extensions/AkavacheExtensions.cs

@@ -166,7 +166,7 @@ public static IObservable<T> GetAndFetchLatestFromIndex<T>(
             this IBlobCache blobCache,
             string key,
             Func<IObservable<T>> fetchFunc,
-            Action<string> removedItemsCallback,
+            Action<T> removedItemsCallback,
             TimeSpan refreshInterval,
             TimeSpan maxCacheDuration)
                 where T : CacheItem
@@ -194,7 +194,7 @@ public static IObservable<T> GetAndFetchLatestFromIndex<T>(
         static IObservable<T> GetAndFetchLatestFromIndex<T>(this IBlobCache This,
             string key,
             Func<IObservable<T>> fetchFunc,
-            Action<string> removedItemsCallback,
+            Action<T> removedItemsCallback,
             Func<DateTimeOffset, bool> fetchPredicate = null,
             DateTimeOffset? absoluteExpiration = null,
             bool shouldInvalidateOnError = false)
@@ -237,7 +237,8 @@ static IObservable<T> GetAndFetchLatestFromIndex<T>(this IBlobCache This,
                     var list = index.OldKeys.Except(index.Keys);
                     if (!list.Any())
                         return;
-                    foreach (var d in list)
+                    var removed = await This.GetObjects<T>(list);
+                    foreach (var d in removed.Values)
                         removedItemsCallback(d);
                     await This.InvalidateObjects<T>(list);
                 })

src/GitHub.App/Models/PullRequestModel.cs

@@ -23,13 +23,6 @@ public PullRequestModel(int number, string title,
             UpdatedAt = updatedAt ?? CreatedAt;
         }
 
-        internal PullRequestModel(int number)
-        {
-            Number = number;
-            Title = "";
-            Author = new AccountDesigner();
-        }
-
         public void CopyFrom(IPullRequestModel other)
         {
             if (!Equals(other))

src/GitHub.App/Services/ModelService.cs

@@ -273,10 +273,6 @@ IPullRequestModel Create(PullRequestCacheItem prCacheItem)
             };
         }
 
-        static IPullRequestModel Create(string key)
-        {
-            return new PullRequestModel(Int32.Parse(key.Split('|').Last(), CultureInfo.InvariantCulture));
-        }
 
         public IObservable<Unit> InsertUser(AccountCacheItem user)
         {