From c3fd04faf943fcc8dead80f009cac49c413eedfe Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 15:52:38 +0200 Subject: [PATCH 01/11] fix(capture-sdk): add break statement to prevent fall-through in switch case PP-1761 --- .../gini/android/capture/analysis/AnalysisScreenPresenter.java | 1 + 1 file changed, 1 insertion(+) diff --git a/capture-sdk/sdk/src/main/java/net/gini/android/capture/analysis/AnalysisScreenPresenter.java b/capture-sdk/sdk/src/main/java/net/gini/android/capture/analysis/AnalysisScreenPresenter.java index 881b400651..cf4e9f02ad 100644 --- a/capture-sdk/sdk/src/main/java/net/gini/android/capture/analysis/AnalysisScreenPresenter.java +++ b/capture-sdk/sdk/src/main/java/net/gini/android/capture/analysis/AnalysisScreenPresenter.java @@ -316,6 +316,7 @@ public Void apply(final AnalysisInteractor.ResultHolder resultHolder, } else { proceedWithExtractions(resultHolder); } + break; case NO_NETWORK_SERVICE: break; default: From 479ed34451e345300fe6658c0f0657453b22f31c Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:12:39 +0200 Subject: [PATCH 02/11] fix(bank-sdk): DocumentAnalyzer screen issues PP-1763 --- .../bank/sdk/exampleapp/core/DocumentAnalyzer.kt | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt index 74267a317f..8fc10135a2 100644 --- a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt +++ b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt @@ -19,6 +19,9 @@ class DocumentAnalyzer @JvmOverloads internal constructor( private val documentManager: DocumentManager<*, *>, coroutineContext: CoroutineContext = Dispatchers.Main ) { + companion object { + private const val LOG_TAG = "gini-api" + } private val coroutineScope = CoroutineScope(coroutineContext) var giniApiDocument: Document? = null @@ -43,26 +46,26 @@ class DocumentAnalyzer @JvmOverloads internal constructor( filename = null, documentType = null ).mapSuccess { partialDocumentResource -> - Log.d("gini-api", "Partial document created: " + partialDocumentResource.data.id) + Log.d(LOG_TAG, "Partial document created: " + partialDocumentResource.data.id) Log.d( - "gini-api", "Creating composite document for partial document: " + partialDocumentResource.data.id + LOG_TAG, "Creating composite document for partial document: " + partialDocumentResource.data.id ) documentManager.createCompositeDocument(listOf(partialDocumentResource.data)) }.mapSuccess { compositeDocumentResource -> - Log.d("gini-api", "Composite document created: " + compositeDocumentResource.data.id) + Log.d(LOG_TAG, "Composite document created: " + compositeDocumentResource.data.id) giniApiDocument = compositeDocumentResource.data Log.d( - "gini-api", "Getting extractions for composite document: " + compositeDocumentResource.data.id + LOG_TAG, "Getting extractions for composite document: " + compositeDocumentResource.data.id ) documentManager.getAllExtractionsWithPolling(compositeDocumentResource.data) } when (extractionsResource) { is Resource.Success -> { - Log.d("gini-api", "Analysis completed for document: ${giniApiDocument?.id}") + Log.d(LOG_TAG, "Analysis completed for document: ${giniApiDocument?.id}") listener?.onExtractionsReceived(extractionsResource.data.specificExtractions) } is Resource.Error -> { - Log.d("gini-api", "Analysis failed for document ${giniApiDocument?.id}: ${extractionsResource!!.message}") + Log.d(LOG_TAG, "Analysis failed for document ${giniApiDocument?.id}: ${extractionsResource!!.message}") listener?.onException(Exception(extractionsResource.message, extractionsResource.exception)) } is Resource.Cancelled -> {} From dd13d3b2367d9ce1216b1627607267a1e37c1c6c Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:16:17 +0200 Subject: [PATCH 03/11] fix(bank-sdk): correct logging of document analysis failure message PP-1763 --- .../gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt index 8fc10135a2..d8a627d29b 100644 --- a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt +++ b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt @@ -65,7 +65,7 @@ class DocumentAnalyzer @JvmOverloads internal constructor( listener?.onExtractionsReceived(extractionsResource.data.specificExtractions) } is Resource.Error -> { - Log.d(LOG_TAG, "Analysis failed for document ${giniApiDocument?.id}: ${extractionsResource!!.message}") + Log.d(LOG_TAG, "Analysis failed for document ${giniApiDocument?.id}: ${extractionsResource.message}") listener?.onException(Exception(extractionsResource.message, extractionsResource.exception)) } is Resource.Cancelled -> {} From 8e6135a1237c6d79912b19fdabf8ef98f0f4b31b Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:19:11 +0200 Subject: [PATCH 04/11] fix(bank-sdk): DigitalInvoiceScreenPresenter.kt issues PP-1771 --- .../sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt index d2ca508f0c..96ab34566c 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt @@ -267,6 +267,7 @@ internal class DigitalInvoiceScreenPresenter( } override fun stop() { + TODO("Not yet implemented") } @VisibleForTesting From 5af36d8628e72cc296ba31ecf8f5e3cdeb2763a4 Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:28:40 +0200 Subject: [PATCH 05/11] fix(bank-sdk): update DigitalInvoiceScreenPresenter to implement stop method as no-op PP-1771 --- .../sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt index 96ab34566c..8913967af7 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoiceScreenPresenter.kt @@ -267,7 +267,7 @@ internal class DigitalInvoiceScreenPresenter( } override fun stop() { - TODO("Not yet implemented") + // No-op } @VisibleForTesting From 44e67c7c7c2f2a4056a3dad972caf8b544411bf8 Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:34:51 +0200 Subject: [PATCH 06/11] fix(bank-sdk): LineItemsAdapter.kt issues PP-1772 --- .../android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt index 5c84c367e6..a0d6b52c9e 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt @@ -445,6 +445,7 @@ internal sealed class ViewHolder(itemView: View, val viewType: ViewType) : } override fun unbind() { + // No operation } } From 80318365adec8d400c46150e85c1d507753cec29 Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Wed, 24 Sep 2025 17:44:32 +0200 Subject: [PATCH 07/11] fix(bank-sdk): add no-op comments for default implementations in various classes --- .../capture/digitalinvoice/details/EditTextExtensions.kt | 2 ++ .../details/LineItemDetailsScreenPresenter.kt | 1 + .../onboarding/DigitalOnboardingScreenPresenter.kt | 2 ++ .../view/DigitalInvoiceNavigationBarBottomAdapter.kt | 8 ++++---- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt index 1a6fcba979..d4d4bdf8b6 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt @@ -14,9 +14,11 @@ import android.widget.EditText internal fun EditText.doAfterTextChanged(afterTextChanged: (String) -> Unit): TextWatcher = object : TextWatcher { override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) { + //no op } override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) { + //no op } override fun afterTextChanged(editable: Editable?) { diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt index c86e82d5ac..b7e45cfe5e 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt @@ -195,6 +195,7 @@ internal class LineItemDetailsScreenPresenter( } override fun stop() { + // No op } } diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt index 544e3d29da..8efc624de8 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt @@ -28,8 +28,10 @@ internal class DigitalOnboardingScreenPresenter( } override fun start() { + //no op } override fun stop() { + //no op } } \ No newline at end of file diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt index 8a44afe552..946d8bd94e 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt @@ -48,7 +48,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * Example value: "3% Skonto discount" */ fun onSkontoPercentageBadgeUpdated(text: String) { - + // no-op: default implementation, override if needed } /** @@ -57,7 +57,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * @param isVisible visibility flag */ fun onSkontoPercentageBadgeVisibilityUpdate(isVisible: Boolean) { - + // no-op: default implementation, override if needed } /** @@ -67,7 +67,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * Example value: `"Save 100.00 EUR"` */ fun onSkontoSavingsAmountUpdated(text: String) { - + // no-op: default implementation, override if needed } /** @@ -76,7 +76,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * @param isVisible visibility flag */ fun onSkontoSavingsAmountVisibilityUpdated(isVisible: Boolean) { - + // no-op: default implementation, override if needed } } From 79eb9ed89436052448ee956e6accfe12208968c6 Mon Sep 17 00:00:00 2001 From: obaidgini Date: Mon, 29 Sep 2025 16:14:41 +0200 Subject: [PATCH 08/11] feat(bank-sdk): shifting the logic of transforming to separate method, because cognitive complexity was very high PP-1769 --- .../capture/digitalinvoice/DigitalInvoice.kt | 91 ++++++++++--------- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt index d00b697190..e97df4e775 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt @@ -301,51 +301,7 @@ internal class DigitalInvoice( _compoundExtractions = compoundExtractions.mapValues { (name, extraction) -> when (name) { "lineItems" -> { - val cameraExtractions = - extraction.specificExtractionMaps.mapIndexed { index, lineItemExtractions -> - selectableLineItems.find { it.lineItem.id.toInt() == index } - ?.let { sli -> - val extractions = - lineItemExtractions.mapValues { (name, lineItemExtraction) -> - when (name) { - "description" -> copyGiniCaptureSpecificExtraction( - lineItemExtraction, - sli.lineItem.description - ) - - "baseGross" -> copyGiniCaptureSpecificExtraction( - lineItemExtraction, - sli.lineItem.rawGrossPrice - ) - - "quantity" -> copyGiniCaptureSpecificExtraction( - lineItemExtraction, - if (sli.selected) { - sli.lineItem.quantity.toString() - } else { - "0" - } - ) - - else -> lineItemExtraction - } - }.toMutableMap() - sli.reason?.let { returnReason -> - extractions.put( - "returnReason", GiniCaptureSpecificExtraction( - "returnReason", - returnReason.id, - "", - null, - emptyList() - ) - ) - } - extractions - } - }.filterNotNull().toMutableList() - - + val cameraExtractions = transformLineItemExtractions(extraction) val userAddedExtractions = selectableLineItems.filter { it.addedByUser } .map { it.lineItem.asGiniExtractionMap() @@ -364,6 +320,51 @@ internal class DigitalInvoice( } } + private fun transformLineItemExtractions(extraction: GiniCaptureCompoundExtraction) : MutableList> { + return extraction.specificExtractionMaps.mapIndexed { index, lineItemExtractions -> + selectableLineItems.find { it.lineItem.id.toInt() == index } + ?.let { sli -> + val extractions = + lineItemExtractions.mapValues { (name, lineItemExtraction) -> + when (name) { + "description" -> copyGiniCaptureSpecificExtraction( + lineItemExtraction, + sli.lineItem.description + ) + + "baseGross" -> copyGiniCaptureSpecificExtraction( + lineItemExtraction, + sli.lineItem.rawGrossPrice + ) + + "quantity" -> copyGiniCaptureSpecificExtraction( + lineItemExtraction, + if (sli.selected) { + sli.lineItem.quantity.toString() + } else { + "0" + } + ) + + else -> lineItemExtraction + } + }.toMutableMap() + sli.reason?.let { returnReason -> + extractions.put( + "returnReason", GiniCaptureSpecificExtraction( + "returnReason", + returnReason.id, + "", + null, + emptyList() + ) + ) + } + extractions + } + }.filterNotNull().toMutableList() + } + fun updateAmountToPayExtractionWithTotalPrice() { val totalPrice = getAmountToPay().toPriceString( selectableLineItems.firstOrNull()?.lineItem?.rawCurrency ?: "EUR" From 5027b0fea8bc11580d9f549bf955c9b5d858c3ea Mon Sep 17 00:00:00 2001 From: obaidgini Date: Mon, 29 Sep 2025 16:38:46 +0200 Subject: [PATCH 09/11] feat(bank-sdk): Removed extra space PP-1769 --- .../android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt index e97df4e775..a022555bf7 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/DigitalInvoice.kt @@ -320,7 +320,7 @@ internal class DigitalInvoice( } } - private fun transformLineItemExtractions(extraction: GiniCaptureCompoundExtraction) : MutableList> { + private fun transformLineItemExtractions(extraction: GiniCaptureCompoundExtraction): MutableList> { return extraction.specificExtractionMaps.mapIndexed { index, lineItemExtractions -> selectableLineItems.find { it.lineItem.id.toInt() == index } ?.let { sli -> From df5644bfe8f7b3278098cb6d8d250068a3dfab44 Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Mon, 13 Oct 2025 17:46:28 +0200 Subject: [PATCH 10/11] fix(bank-sdk): reorganize companion object and improve code formatting PP-1763 --- .../android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt index d8a627d29b..c3d9a70d72 100644 --- a/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt +++ b/bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/core/DocumentAnalyzer.kt @@ -19,9 +19,6 @@ class DocumentAnalyzer @JvmOverloads internal constructor( private val documentManager: DocumentManager<*, *>, coroutineContext: CoroutineContext = Dispatchers.Main ) { - companion object { - private const val LOG_TAG = "gini-api" - } private val coroutineScope = CoroutineScope(coroutineContext) var giniApiDocument: Document? = null @@ -85,4 +82,8 @@ class DocumentAnalyzer @JvmOverloads internal constructor( fun onException(exception: Exception) fun onExtractionsReceived(extractions: Map) } + + companion object { + private const val LOG_TAG = "gini-api" + } } \ No newline at end of file From 9ca3c14eaef779d8d3fcb3c47d6f26ec874e1da3 Mon Sep 17 00:00:00 2001 From: mozhganpeivandiansharbaf Date: Tue, 14 Oct 2025 14:29:05 +0200 Subject: [PATCH 11/11] fix(bank-sdk): standardize no-op comments across multiple files PP-1772 --- .../bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt | 2 +- .../capture/digitalinvoice/details/EditTextExtensions.kt | 4 ++-- .../details/LineItemDetailsScreenPresenter.kt | 2 +- .../onboarding/DigitalOnboardingScreenPresenter.kt | 4 ++-- .../view/DigitalInvoiceNavigationBarBottomAdapter.kt | 8 ++++---- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt index a0d6b52c9e..3c77d08a45 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/LineItemsAdapter.kt @@ -445,7 +445,7 @@ internal sealed class ViewHolder(itemView: View, val viewType: ViewType) : } override fun unbind() { - // No operation + /* no-op */ } } diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt index d4d4bdf8b6..2cf7027f5d 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/EditTextExtensions.kt @@ -14,11 +14,11 @@ import android.widget.EditText internal fun EditText.doAfterTextChanged(afterTextChanged: (String) -> Unit): TextWatcher = object : TextWatcher { override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) { - //no op + /* no-op */ } override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) { - //no op + /* no-op */ } override fun afterTextChanged(editable: Editable?) { diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt index b7e45cfe5e..3e41a4b9b7 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/details/LineItemDetailsScreenPresenter.kt @@ -195,7 +195,7 @@ internal class LineItemDetailsScreenPresenter( } override fun stop() { - // No op + /* no-op */ } } diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt index 8efc624de8..6ac1888d36 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/onboarding/DigitalOnboardingScreenPresenter.kt @@ -28,10 +28,10 @@ internal class DigitalOnboardingScreenPresenter( } override fun start() { - //no op + /* no-op */ } override fun stop() { - //no op + /* no-op */ } } \ No newline at end of file diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt index 946d8bd94e..00d26f1721 100644 --- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt +++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/digitalinvoice/view/DigitalInvoiceNavigationBarBottomAdapter.kt @@ -48,7 +48,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * Example value: "3% Skonto discount" */ fun onSkontoPercentageBadgeUpdated(text: String) { - // no-op: default implementation, override if needed + /* no-op */ } /** @@ -57,7 +57,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * @param isVisible visibility flag */ fun onSkontoPercentageBadgeVisibilityUpdate(isVisible: Boolean) { - // no-op: default implementation, override if needed + /* no-op */ } /** @@ -67,7 +67,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * Example value: `"Save 100.00 EUR"` */ fun onSkontoSavingsAmountUpdated(text: String) { - // no-op: default implementation, override if needed + /* no-op */ } /** @@ -76,7 +76,7 @@ interface DigitalInvoiceNavigationBarBottomAdapter : InjectedViewAdapter { * @param isVisible visibility flag */ fun onSkontoSavingsAmountVisibilityUpdated(isVisible: Boolean) { - // no-op: default implementation, override if needed + /* no-op */ } }