Build on travis #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesome
reviewed
Nov 29, 2016
| HTMLCOV_DIR ?= htmlcov | ||
|
|
||
| test: flake8 test_lib | ||
| test: flake8 pylint pytest |
There was a problem hiding this comment.
just curious why you use both flake8 and pylint? the other projects just seem to use flake8?
Collaborator
Author
There was a problem hiding this comment.
They pick up different errors. Flake8 is pyflakes + pep8 checking, whereas pylint has its own set of rules. There is some overlap but it's nicer to use both.
kooba
reviewed
Nov 30, 2016
| Documentation | ||
| ------------- | ||
|
|
||
| See `<http://sqlalchemy-diff.readthedocs.org>`_. |
Contributor
|
Looks great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.