Skip to content

convert client certificate hostnames to lowercase #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

convert client certificate hostnames to lowercase #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3a9a0d
convert client certificate hostnames to lowercase
alexskr Mar 13, 2018
936d665
add spec tests for capitalizaton of certname
alexskr Mar 14, 2018
396b9a0
Merge with upstream
alexskr Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@
$ini_settings = {
'server' => { setting => 'server', value => $server,},
'ca_server' => { setting => 'ca_server', value => $ca_server,},
'certname' => { setting => 'certname', value => $certname,},
# certname must be lower case
# see https://puppet.com/docs/puppet/latest/configuration.html#certname and https://tickets.puppetlabs.com/browse/PUP-2551
'certname' => { setting => 'certname', value => downcase($certname),},
'environment' => { setting => 'environment', value => $env,},
'trusted_node_data' => { setting => 'trusted_node_data', value => true,},
'graph' => { setting => 'graph', value => $graph,},
Expand Down
15 changes: 15 additions & 0 deletions spec/classes/init_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,21 @@
end
end

describe 'with certname containing capitalization' do
let(:params) { { :certname => 'puppet.example.COM' } }

it do
should contain_ini_setting('certname').with({
:ensure => 'present',
:setting => 'certname',
:value => 'puppet.example.com',
:path => '/etc/puppetlabs/puppet/puppet.conf',
:section => 'main',
:require => 'File[puppet_config]',
})
end
end

describe 'with custom_settings specified' do
let(:params) { {
:custom_settings => {
Expand Down