From 424d6b6ecdcbfb5bafb901eee318318f5de99d1f Mon Sep 17 00:00:00 2001 From: Rohan Agarwal Date: Fri, 30 May 2025 12:15:41 -0700 Subject: [PATCH 1/4] Fix automation onboarding condition --- .../app/views/issueDetails/streamline/sidebar/seerNotices.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx index d93de1ad432d39..114f5731e9228d 100644 --- a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx +++ b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx @@ -113,7 +113,9 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice !codeMappingRepos?.length && !isLoadingPreferences; const needsAutomation = - project.autofixAutomationTuning === 'off' && isAutomationAllowed; + (project.autofixAutomationTuning === 'off' || + project.autofixAutomationTuning === undefined) && + isAutomationAllowed; const needsFixabilityView = !views.some(view => view.query.includes(FieldKey.ISSUE_SEER_ACTIONABILITY)) && isAutomationAllowed; From 3d28226998799eb87cd0ddaf5beb2f06376c8213 Mon Sep 17 00:00:00 2001 From: Rohan Agarwal Date: Fri, 30 May 2025 12:35:07 -0700 Subject: [PATCH 2/4] Add starred views FF --- .../app/views/issueDetails/streamline/sidebar/seerNotices.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx index 114f5731e9228d..f83c9ddf7a7deb 100644 --- a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx +++ b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx @@ -118,7 +118,8 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice isAutomationAllowed; const needsFixabilityView = !views.some(view => view.query.includes(FieldKey.ISSUE_SEER_ACTIONABILITY)) && - isAutomationAllowed; + isAutomationAllowed && + organization.features.includes('issue-stream-custom-views'); // Warning conditions const hasMultipleUnreadableRepos = unreadableRepos.length > 1; From 66589c19c29c9137748acdbc7bd0daaf97393567 Mon Sep 17 00:00:00 2001 From: Rohan Agarwal Date: Fri, 30 May 2025 12:35:59 -0700 Subject: [PATCH 3/4] Add issue views FF --- .../views/issueDetails/streamline/sidebar/seerNotices.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx index f83c9ddf7a7deb..a568cffd1fba27 100644 --- a/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx +++ b/static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx @@ -97,6 +97,9 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice const isAutomationAllowed = organization.features.includes( 'trigger-autofix-on-issue-summary' ); + const isStarredViewAllowed = organization.features.includes( + 'issue-stream-custom-views' + ); const unreadableRepos = repos.filter(repo => repo.is_readable === false); const githubRepos = unreadableRepos.filter(repo => repo.provider.includes('github')); @@ -119,7 +122,7 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice const needsFixabilityView = !views.some(view => view.query.includes(FieldKey.ISSUE_SEER_ACTIONABILITY)) && isAutomationAllowed && - organization.features.includes('issue-stream-custom-views'); + isStarredViewAllowed; // Warning conditions const hasMultipleUnreadableRepos = unreadableRepos.length > 1; @@ -303,7 +306,7 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice )} {/* Step 4: Fixability View */} - {isAutomationAllowed && ( + {isAutomationAllowed && isStarredViewAllowed && ( Date: Fri, 30 May 2025 12:44:52 -0700 Subject: [PATCH 4/4] Fix test --- .../streamline/sidebar/seerNotices.spec.tsx | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/static/app/views/issueDetails/streamline/sidebar/seerNotices.spec.tsx b/static/app/views/issueDetails/streamline/sidebar/seerNotices.spec.tsx index e5e3fe6b742e7c..6b4c7c6ecc35aa 100644 --- a/static/app/views/issueDetails/streamline/sidebar/seerNotices.spec.tsx +++ b/static/app/views/issueDetails/streamline/sidebar/seerNotices.spec.tsx @@ -81,7 +81,10 @@ describe('SeerNotices', function () { it('shows fixability view step if automation is allowed and view not starred', () => { const project = getProjectWithAutomation('high'); render(, { - organization, + organization: { + ...organization, + features: ['issue-stream-custom-views', 'trigger-autofix-on-issue-summary'], + }, }); expect(screen.getByText('Get Some Quick Wins')).toBeInTheDocument(); expect(screen.getByText('Star Recommended View')).toBeInTheDocument(); @@ -99,7 +102,12 @@ describe('SeerNotices', function () { }); const project = getProjectWithAutomation('medium'); render(, { - ...{organization: {...organization, features: []}}, + ...{ + organization: { + ...organization, + features: [], + }, + }, }); // Should not find any step titles expect(screen.queryByText('Set Up the GitHub Integration')).not.toBeInTheDocument();