Fix query routing for TSDB distinct counter and frequency table delete operations. #5451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaemming
commented
May 25, 2017
| vnodes=64, | ||
| enable_frequency_sketches=True, | ||
| hosts={ | ||
| i - 6: {'db': i} for i in xrange(6, 9) |
Contributor
Author
There was a problem hiding this comment.
All other tests typically run on db 9 so I just picked some arbitrary numbers around there
mattrobenolt
approved these changes
May 25, 2017
LewisJEllis
approved these changes
May 25, 2017
tests/sentry/tsdb/test_redis.py
Outdated
| ) | ||
|
|
||
| def tearDown(self): | ||
| with self.db.cluster.fanout('all') as client: |
Contributor
There was a problem hiding this comment.
I guess docs say it's the same exact thing, but can we do
with self.db.cluster.all() as client:here? Or do we prefer having "fanout" in there to hint at what's going on?
Contributor
Author
There was a problem hiding this comment.
No specific reason to prefer one over the other, I just went with the one that I remembered exists. I changed it to .all because it seems more reliable to use a method here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight as part of GH-5317, and wasn't caught in tests because the test suite didn't actually run the tests against multiple databases. The easiest way to test this (other than depending on the tests to have the correct behavior) is to cross-reference the routing logic in the other mutation commands and make sure it's consistent.