fix(github_webhooks): Reset org tags and context before available #45139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context The only code that sets these three pieces of information is within the sdk.py module (see #45134 for details). This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. It is unclear if the root cause comes from a bug in the SDK or the way we tag things in our code base. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. A sample event can be seen [here](https://sentry.sentry.io/discover/sentry:99c8b9c9d2c241cc90e52c307faa45eb/?field=organization.slug&field=user.display&field=timestamp&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=issue%3ASENTRY-W7T&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29) (private link) Here's a [query](https://sentry.sentry.io/discover/results/?field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&statsPeriod=14d&yAxis=count%28%29) showing some transactions that should not have org values set. There may be more transaction since I'm narrowing the query down to just `error.value:"Integration matching query does not exist."` Improves [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464)
armenzg
changed the title
github-actions
bot
added
the
Scope: Backend
scttcper
approved these changes
Feb 28, 2023
armenzg
added a commit
that referenced
this pull request
Mar 3, 2023
This is a follow up to #45139 for JIRA and Github enterprise. It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. Here's a [query](https://sentry.sentry.io/discover/results/?end=2023-03-04T04%3A59%3A59&field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&start=2023-03-02T05%3A00%3A00&yAxis=count%28%29) showing transactions that should not have org values set. Fix [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464)
armenzg
added a commit
that referenced
this pull request
Mar 3, 2023
This is a follow up to #45139 for JIRA and Github enterprise. It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. Here's a [query](https://sentry.sentry.io/discover/results/?end=2023-03-04T04%3A59%3A59&field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&start=2023-03-02T05%3A00%3A00&yAxis=count%28%29) showing transactions that should not have org values set. Fixes [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464) [WOR-2464]: https://getsentry.atlassian.net/browse/WOR-2464?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we're tagging events with information about organizations even when it's impossible to have any org info.
We have events tagged with the following info even when it is not possible:
The only code that sets these three pieces of information is within the sdk.py module (see #45134 for details).
This issues causes finding errors that are for the wrong organization when using
organization.slug, thus, wasting time for engineers and customer support.It is unclear if the root cause comes from a bug in the SDK or the way we tag things in our code base.
This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue.
A sample event can be seen here (private link)
Here's a query showing some transactions that should not have org values set. There may be more transaction since I'm narrowing the query down to just
error.value:"Integration matching query does not exist."Improves WOR-2464