Skip to content

fix: Correct API usage for Crons #42886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: Correct API usage for Crons #42886

merged 1 commit into from
Jan 6, 2023

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jan 6, 2023 •
edited
Loading

  • Remove legacy docstrings and replace with better descriptions
  • Missing checkin details endpoint for Hybrid Cloud

Refs #42850

@dcramer dcramer requested a review from a team as a code owner January 6, 2023 18:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2023
@dcramer dcramer force-pushed the feat/add-cron-examples branch from 3daa4fa to 8f641b9 Compare January 6, 2023 18:46
@dcramer dcramer changed the title feat: Add OpenAPI examples for checkins ref: Improve OpenAPI documentation for Crons Jan 6, 2023
@dcramer dcramer force-pushed the feat/add-cron-examples branch from 8f641b9 to 52b048e Compare January 6, 2023 18:51
@dcramer dcramer force-pushed the feat/add-cron-examples branch from 52b048e to 56c3f5e Compare January 6, 2023 19:29
@dcramer dcramer force-pushed the feat/add-cron-examples branch from 56c3f5e to 4ffa132 Compare January 6, 2023 19:56
@dcramer dcramer changed the title ref: Improve OpenAPI documentation for Crons fix: Correct API usage for Crons Jan 6, 2023
markstory
markstory approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vercel
Copy link

vercel bot commented Jan 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry 🔄 Building (Inspect) Jan 6, 2023 at 9:09PM (UTC)
storybook 🔄 Building (Inspect) Jan 6, 2023 at 9:09PM (UTC)

@dcramer
fix: Correct API usage for Crons
1507f76 
- Remove legacy docstrings and replace with better descriptions
- Missing checkin details endpoint for Hybrid Cloud
@dcramer dcramer force-pushed the feat/add-cron-examples branch from 32681ce to 1507f76 Compare January 6, 2023 21:08
@dcramer dcramer merged commit 8634c54 into master Jan 6, 2023
@dcramer dcramer deleted the feat/add-cron-examples branch January 6, 2023 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markstory markstory markstory approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcramer @markstory