From 9fd20cc9132da247cfd3c930c514b959cb3f7f39 Mon Sep 17 00:00:00 2001 From: Vladan Paunovic Date: Wed, 10 Aug 2022 12:33:31 +0200 Subject: [PATCH 1/2] fix(vercel): add sentry env vars to all default environments in Vercel --- src/sentry/integrations/vercel/integration.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sentry/integrations/vercel/integration.py b/src/sentry/integrations/vercel/integration.py index 64f172fb242c6a..975a80a24db6e6 100644 --- a/src/sentry/integrations/vercel/integration.py +++ b/src/sentry/integrations/vercel/integration.py @@ -253,7 +253,7 @@ def create_env_var(self, client, vercel_project_id, key, value, type): data = { "key": key, "value": value, - "target": ["production"], + "target": ["production", "preview", "development"], "type": type, } try: From a40f868bd5c7689dfd10a83597363cdc98bfa864 Mon Sep 17 00:00:00 2001 From: Vladan Paunovic Date: Wed, 10 Aug 2022 12:58:04 +0200 Subject: [PATCH 2/2] chore: update tests --- .../integrations/vercel/test_integration.py | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/sentry/integrations/vercel/test_integration.py b/tests/sentry/integrations/vercel/test_integration.py index e435bda60333aa..bd309f1ff853bb 100644 --- a/tests/sentry/integrations/vercel/test_integration.py +++ b/tests/sentry/integrations/vercel/test_integration.py @@ -169,7 +169,7 @@ def test_update_organization_config(self): json={ "key": env_var, "value": details["value"], - "target": ["production"], + "target": ["production", "preview", "development"], "type": details["type"], }, ) @@ -192,30 +192,30 @@ def test_update_organization_config(self): req_params = json.loads(responses.calls[5].request.body) assert req_params["key"] == "SENTRY_ORG" assert req_params["value"] == org.slug - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[6].request.body) assert req_params["key"] == "SENTRY_PROJECT" assert req_params["value"] == self.project.slug - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[7].request.body) assert req_params["key"] == "NEXT_PUBLIC_SENTRY_DSN" assert req_params["value"] == enabled_dsn - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[8].request.body) assert req_params["key"] == "SENTRY_AUTH_TOKEN" - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[9].request.body) assert req_params["key"] == "VERCEL_GIT_COMMIT_SHA" assert req_params["value"] == "VERCEL_GIT_COMMIT_SHA" - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "system" @responses.activate @@ -270,7 +270,7 @@ def test_update_org_config_vars_exist(self): json={ "key": env_var, "value": details["value"], - "target": ["production"], + "target": ["production", "preview", "development"], "type": details["type"], }, ) @@ -292,30 +292,30 @@ def test_update_org_config_vars_exist(self): req_params = json.loads(responses.calls[5].request.body) assert req_params["key"] == "SENTRY_ORG" assert req_params["value"] == org.slug - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[8].request.body) assert req_params["key"] == "SENTRY_PROJECT" assert req_params["value"] == self.project.slug - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[11].request.body) assert req_params["key"] == "SENTRY_DSN" assert req_params["value"] == enabled_dsn - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[14].request.body) assert req_params["key"] == "SENTRY_AUTH_TOKEN" - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "encrypted" req_params = json.loads(responses.calls[17].request.body) assert req_params["key"] == "VERCEL_GIT_COMMIT_SHA" assert req_params["value"] == "VERCEL_GIT_COMMIT_SHA" - assert req_params["target"] == ["production"] + assert req_params["target"] == ["production", "preview", "development"] assert req_params["type"] == "system" @responses.activate