Skip to content

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Aug 21, 2020

@AbhiPrasad AbhiPrasad requested a review from billyvg August 21, 2020 18:35
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner August 21, 2020 18:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2020

size-limit report

Path Size
public/app.js 207.84 KB (+0.1% 🔺)
public/vendor.js 442.2 KB (+0.14% 🔺)

@AbhiPrasad AbhiPrasad changed the title feat(deps): Update JS SDK to 5.21.2 feat(deps): Update JS SDK to 5.21.3 Aug 21, 2020
@dashed
Copy link
Member

dashed commented Aug 24, 2020

@AbhiPrasad this isn't compiling because of the incompatible types for history v3:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d9ed79665140be79df1b982a9e4c90c153b1222e/types/history/v3/index.d.ts#L14-L28

I've previously made changes to this type to be able to import the ts definitions into this repo: DefinitelyTyped/DefinitelyTyped#37657

I'm wondering if we can make use of generics to infer the type?

@dashed
Copy link
Member

dashed commented Aug 24, 2020

@AbhiPrasad let's mark this as any to unblock the merge. I can take look at this later.

@AbhiPrasad AbhiPrasad changed the title feat(deps): Update JS SDK to 5.21.3 feat(deps): Update JS SDK to 5.21.4 Aug 24, 2020
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Aug 24, 2020

Switched to any type. We ended up having to cut another release because stale build files got uploaded 😅

@AbhiPrasad AbhiPrasad merged commit 7c78e6d into master Aug 24, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/js-sdk-5.21.2 branch August 24, 2020 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants