feat: Add React Router Instrumentation for Tracing #20031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was left over from testing
dashed
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes in this PR.
Switch from
@sentry/apm->@sentry/tracing. All that happened here was that we changed fromIntegrations.TracingtoIntegrations.BrowserTracingUse custom routing instrumentation for
react-router. See the PR for this here: feat: Add instrumentation for React Router v3 sentry-javascript#2759Bump to SDK version
5.20.1. This patch includes a fix for a bug where we were incorrectly recording pageload durations, please see the PR for more details and possible consquences of it: fix(apm/tracing): update pageload op transaction start timestamps sentry-javascript#2773 (comment)