From 7d9b836854201eb402aa614f4ae2c09614ba3fdb Mon Sep 17 00:00:00 2001 From: Evan Purkhiser Date: Wed, 17 Jul 2019 16:22:31 -0700 Subject: [PATCH] ref(onboarding): Rename wizardNew -> onboarding --- src/sentry/static/sentry/app/routes.jsx | 2 +- .../{wizardNew.jsx => onboarding.jsx} | 4 +-- .../sentry/app/views/onboarding/platform.jsx | 2 +- .../views/onboarding/projectSetup/index.jsx | 2 +- .../sentry/app/views/onboarding/welcome.jsx | 2 +- ...wizardNew.spec.jsx => onboarding.spec.jsx} | 27 ++++++++----------- 6 files changed, 17 insertions(+), 22 deletions(-) rename src/sentry/static/sentry/app/views/onboarding/{wizardNew.jsx => onboarding.jsx} (98%) rename tests/js/spec/views/onboarding/{wizardNew.spec.jsx => onboarding.spec.jsx} (84%) diff --git a/src/sentry/static/sentry/app/routes.jsx b/src/sentry/static/sentry/app/routes.jsx index e2fae1c99a7e27..ca47744b17883b 100644 --- a/src/sentry/static/sentry/app/routes.jsx +++ b/src/sentry/static/sentry/app/routes.jsx @@ -798,7 +798,7 @@ function routes() { - import(/* webpackChunkName: "OnboardingWizardNew" */ 'app/views/onboarding/wizardNew') + import(/* webpackChunkName: "Onboarding" */ 'app/views/onboarding/onboarding') } component={errorHandler(LazyLoad)} /> diff --git a/src/sentry/static/sentry/app/views/onboarding/wizardNew.jsx b/src/sentry/static/sentry/app/views/onboarding/onboarding.jsx similarity index 98% rename from src/sentry/static/sentry/app/views/onboarding/wizardNew.jsx rename to src/sentry/static/sentry/app/views/onboarding/onboarding.jsx index 4b5b70648f13cd..8f247f301f54ee 100644 --- a/src/sentry/static/sentry/app/views/onboarding/wizardNew.jsx +++ b/src/sentry/static/sentry/app/views/onboarding/onboarding.jsx @@ -50,7 +50,7 @@ const stepShape = PropTypes.shape({ Component: PropTypes.func, }); -class OnboardingWizard extends React.Component { +class Onboarding extends React.Component { static propTypes = { steps: PropTypes.arrayOf(stepShape), projects: PropTypes.arrayOf(SentryTypes.Project), @@ -327,4 +327,4 @@ export const stepPropTypes = { onUpdate: PropTypes.func, }; -export default withOrganization(withProjects(OnboardingWizard)); +export default withOrganization(withProjects(Onboarding)); diff --git a/src/sentry/static/sentry/app/views/onboarding/platform.jsx b/src/sentry/static/sentry/app/views/onboarding/platform.jsx index 0850c32c9e0707..5458291e743201 100644 --- a/src/sentry/static/sentry/app/views/onboarding/platform.jsx +++ b/src/sentry/static/sentry/app/views/onboarding/platform.jsx @@ -4,7 +4,7 @@ import React from 'react'; import {addErrorMessage} from 'app/actionCreators/indicator'; import {createProject} from 'app/actionCreators/projects'; -import {stepPropTypes} from 'app/views/onboarding/wizardNew'; +import {stepPropTypes} from 'app/views/onboarding/onboarding'; import {t, tct} from 'app/locale'; import Button from 'app/components/button'; import PlatformPicker from 'app/components/platformPicker'; diff --git a/src/sentry/static/sentry/app/views/onboarding/projectSetup/index.jsx b/src/sentry/static/sentry/app/views/onboarding/projectSetup/index.jsx index 123150723c22c0..2ec44ea6788553 100644 --- a/src/sentry/static/sentry/app/views/onboarding/projectSetup/index.jsx +++ b/src/sentry/static/sentry/app/views/onboarding/projectSetup/index.jsx @@ -2,7 +2,7 @@ import React from 'react'; import posed, {PoseGroup} from 'react-pose'; import {analytics} from 'app/utils/analytics'; -import {stepPropTypes} from 'app/views/onboarding/wizardNew'; +import {stepPropTypes} from 'app/views/onboarding/onboarding'; import {t} from 'app/locale'; import HookOrDefault from 'app/components/hookOrDefault'; import SentryTypes from 'app/sentryTypes'; diff --git a/src/sentry/static/sentry/app/views/onboarding/welcome.jsx b/src/sentry/static/sentry/app/views/onboarding/welcome.jsx index 7d2307076b17b9..5252f5597f7597 100644 --- a/src/sentry/static/sentry/app/views/onboarding/welcome.jsx +++ b/src/sentry/static/sentry/app/views/onboarding/welcome.jsx @@ -2,7 +2,7 @@ import React from 'react'; import styled from 'react-emotion'; import {analytics} from 'app/utils/analytics'; -import {stepPropTypes} from 'app/views/onboarding/wizardNew'; +import {stepPropTypes} from 'app/views/onboarding/onboarding'; import {t, tct} from 'app/locale'; import Button from 'app/components/button'; import SentryTypes from 'app/sentryTypes'; diff --git a/tests/js/spec/views/onboarding/wizardNew.spec.jsx b/tests/js/spec/views/onboarding/onboarding.spec.jsx similarity index 84% rename from tests/js/spec/views/onboarding/wizardNew.spec.jsx rename to tests/js/spec/views/onboarding/onboarding.spec.jsx index 9751bf59522243..d1199fd08edf42 100644 --- a/tests/js/spec/views/onboarding/wizardNew.spec.jsx +++ b/tests/js/spec/views/onboarding/onboarding.spec.jsx @@ -3,7 +3,7 @@ import React from 'react'; import {initializeOrg} from 'app-test/helpers/initializeOrg'; import {mount} from 'enzyme'; -import OnboardingWizard, {stepPropTypes} from 'app/views/onboarding/wizardNew'; +import Onboarding, {stepPropTypes} from 'app/views/onboarding/onboarding'; import ProjectsStore from 'app/stores/projectsStore'; const MockStep = ({ @@ -11,9 +11,7 @@ const MockStep = ({ data, scrollTargetId, active, - orgId, project, - platform, onReturnToStep, onComplete, onUpadte, @@ -24,9 +22,9 @@ const MockStep = ({ {name}
{project && project.slug}
- onComplete(data)} /> - onUpadte(data)} /> - onReturnToStep(data)} /> + onComplete(data)} /> + onUpadte(data)} /> + onReturnToStep(data)} /> ); @@ -52,7 +50,7 @@ const MOCKED_STEPS = [ }, ]; -describe('OnboardingWizard', function() { +describe('Onboarding', function() { it('redirects to first step if invalid step ID present', function() { browserHistory.replace = jest.fn(); @@ -61,10 +59,7 @@ describe('OnboardingWizard', function() { orgId: 'org-bar', }; - mount( - , - TestStubs.routerContext() - ); + mount(, TestStubs.routerContext()); expect(browserHistory.replace).toHaveBeenCalledWith('/onboarding/org-bar/step1/'); }); @@ -76,7 +71,7 @@ describe('OnboardingWizard', function() { }; const wrapper = mount( - , + , TestStubs.routerContext() ); @@ -106,7 +101,7 @@ describe('OnboardingWizard', function() { }; const wrapper = mount( - , + , TestStubs.routerContext() ); @@ -121,7 +116,7 @@ describe('OnboardingWizard', function() { }; const wrapper = mount( - , + , TestStubs.routerContext() ); @@ -163,7 +158,7 @@ describe('OnboardingWizard', function() { }; const wrapper = mount( - , + , TestStubs.routerContext() ); @@ -192,7 +187,7 @@ describe('OnboardingWizard', function() { }; const wrapper = mount( - , + , routerContext );