feat(uptime): Implement detector handler

Author: evanpurkhiser

src/sentry/uptime/consumers/results_consumer.py

@@ -26,6 +26,7 @@
 )
 from sentry.uptime.detectors.ranking import _get_cluster
 from sentry.uptime.detectors.result_handler import handle_onboarding_result
+from sentry.uptime.grouptype import DetectorPacketValue
 from sentry.uptime.issue_platform import create_issue_platform_occurrence, resolve_uptime_issue
 from sentry.uptime.models import (
     UptimeStatus,
@@ -43,11 +44,17 @@
     send_uptime_config_deletion,
     update_remote_uptime_subscription,
 )
-from sentry.uptime.types import IncidentStatus, ProjectUptimeSubscriptionMode
+from sentry.uptime.types import (
+    DATA_SOURCE_UPTIME_SUBSCRIPTION,
+    IncidentStatus,
+    ProjectUptimeSubscriptionMode,
+)
 from sentry.utils import metrics
 from sentry.utils.arroyo_producer import SingletonProducer
 from sentry.utils.kafka_config import get_kafka_producer_cluster_options, get_topic_definition
+from sentry.workflow_engine.models.data_source import DataPacket
 from sentry.workflow_engine.models.detector import Detector
+from sentry.workflow_engine.processors.data_packet import process_data_packets
 
 logger = logging.getLogger(__name__)
 
@@ -292,6 +299,16 @@ def handle_active_result(
     result: CheckResult,
     metric_tags: dict[str, str],
 ):
+    if features.has("organizations:uptime-detector-handler", detector.project.organization):
+        packet = DetectorPacketValue(
+            check_result=result,
+            subscription=uptime_subscription,
+        )
+        process_data_packets(
+            [DataPacket[DetectorPacketValue](source_id=result["subscription_id"], packet=packet)],
+            DATA_SOURCE_UPTIME_SUBSCRIPTION,
+        )
+
     uptime_status = uptime_subscription.uptime_status
     result_status = result["status"]
 

src/sentry/uptime/grouptype.py

@@ -1,15 +1,123 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
+from typing import override
+
+from sentry_kafka_schemas.schema_types.uptime_results_v1 import CheckResult, CheckStatus
 
 from sentry.issues.grouptype import GroupCategory, GroupType
+from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.ratelimits.sliding_windows import Quota
 from sentry.types.group import PriorityLevel
+from sentry.uptime.models import UptimeSubscription
 from sentry.uptime.types import (
     GROUP_TYPE_UPTIME_DOMAIN_CHECK_FAILURE,
     ProjectUptimeSubscriptionMode,
 )
-from sentry.workflow_engine.types import DetectorSettings
+from sentry.workflow_engine.handlers.detector.base import DetectorOccurrence, EventData
+from sentry.workflow_engine.handlers.detector.stateful import (
+    DetectorThresholds,
+    StatefulDetectorHandler,
+)
+from sentry.workflow_engine.models import DataPacket, Detector
+from sentry.workflow_engine.processors.data_condition_group import ProcessedDataConditionGroup
+from sentry.workflow_engine.types import DetectorPriorityLevel, DetectorSettings
+
+
+@dataclass(frozen=True)
+class DetectorPacketValue:
+    """
+    Represents the value passed into the uptime detector
+    """
+
+    check_result: CheckResult
+    subscription: UptimeSubscription
+
+
+def build_detector_fingerprint_component(detector: Detector) -> str:
+    return f"uptime-detector:{detector.id}"
+
+
+def build_fingerprint(detector: Detector) -> list[str]:
+    return [build_detector_fingerprint_component(detector)]
+
+
+class UptimeDetectorHandler(StatefulDetectorHandler[DetectorPacketValue, CheckStatus]):
+    @override
+    @property
+    def thresholds(self) -> DetectorThresholds:
+        """
+        Require 3 uptime checks to fail before activating the detector.
+        Likewise require 3 successful checks to recover.
+        """
+        return {
+            DetectorPriorityLevel.OK: 3,
+            DetectorPriorityLevel.HIGH: 3,
+        }
+
+    @override
+    def extract_value(self, data_packet: DataPacket[DetectorPacketValue]) -> CheckStatus:
+        return data_packet.packet.check_result["status"]
+
+    @override
+    def build_issue_fingerprint(self) -> list[str]:
+        return build_fingerprint(self.detector)
+
+    @override
+    def create_occurrence(
+        self,
+        evaluation_result: ProcessedDataConditionGroup,
+        data_packet: DataPacket[DetectorPacketValue],
+        priority: DetectorPriorityLevel,
+    ) -> tuple[DetectorOccurrence, EventData]:
+        result = data_packet.packet.check_result
+        uptime_subscription = data_packet.packet.subscription
+
+        evidence_display: list[IssueEvidence] = []
+
+        status_reason = result["status_reason"]
+        if status_reason:
+            reason_evidence = IssueEvidence(
+                name="Failure reason",
+                value=f'{status_reason["type"]} - {status_reason["description"]}',
+                important=True,
+            )
+            evidence_display.extend([reason_evidence])
+
+        evidence_display.append(
+            IssueEvidence(
+                name="Duration",
+                value=f"{result["duration_ms"]}ms",
+                important=False,
+            ),
+        )
+
+        request_info = result["request_info"]
+        if request_info:
+            method_evidence = IssueEvidence(
+                name="Method",
+                value=request_info["request_type"],
+                important=False,
+            )
+            status_code_evidence = IssueEvidence(
+                name="Status Code",
+                value=str(request_info["http_status_code"]),
+                important=False,
+            )
+            evidence_display.extend([method_evidence, status_code_evidence])
+
+        occurrence = DetectorOccurrence(
+            issue_title=f"Downtime detected for {uptime_subscription.url}",
+            subtitle="Your monitored domain is down",
+            evidence_display=evidence_display,
+            type=UptimeDomainCheckFailure,
+            level="error",
+            culprit="",  # TODO: The url?
+            assignee=self.detector.owner,
+            priority=priority,
+        )
+
+        return (occurrence, {})
 
 
 @dataclass(frozen=True)
@@ -24,6 +132,7 @@ class UptimeDomainCheckFailure(GroupType):
     enable_auto_resolve = False
     enable_escalation_detection = False
     detector_settings = DetectorSettings(
+        handler=UptimeDetectorHandler,
         config_schema={
             "$schema": "https://json-schema.org/draft/2020-12/schema",
             "description": "A representation of an uptime alert",

src/sentry/uptime/issue_platform.py

@@ -9,7 +9,7 @@
 from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
 from sentry.issues.status_change_message import StatusChangeMessage
 from sentry.models.group import GroupStatus
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
+from sentry.uptime.grouptype import UptimeDomainCheckFailure, build_fingerprint
 from sentry.uptime.models import get_project_subscription, get_uptime_subscription
 from sentry.workflow_engine.models.detector import Detector
 
@@ -24,14 +24,6 @@ def create_issue_platform_occurrence(result: CheckResult, detector: Detector):
     )
 
 
-def build_detector_fingerprint_component(detector: Detector) -> str:
-    return f"uptime-detector:{detector.id}"
-
-
-def build_fingerprint(detector: Detector) -> list[str]:
-    return [build_detector_fingerprint_component(detector)]
-
-
 def build_occurrence_from_result(result: CheckResult, detector: Detector) -> IssueOccurrence:
     uptime_subscription = get_uptime_subscription(detector)
     status_reason = result["status_reason"]

tests/sentry/uptime/consumers/test_results_consumer.py

@@ -38,8 +38,7 @@
     build_onboarding_failure_key,
 )
 from sentry.uptime.detectors.tasks import is_failed_url
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
-from sentry.uptime.issue_platform import build_detector_fingerprint_component
+from sentry.uptime.grouptype import UptimeDomainCheckFailure, build_detector_fingerprint_component
 from sentry.uptime.models import (
     ProjectUptimeSubscription,
     UptimeStatus,

tests/sentry/uptime/subscriptions/test_subscriptions.py

@@ -15,11 +15,8 @@
 from sentry.testutils.helpers import override_options
 from sentry.testutils.skips import requires_kafka
 from sentry.types.actor import Actor
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
-from sentry.uptime.issue_platform import (
-    build_detector_fingerprint_component,
-    create_issue_platform_occurrence,
-)
+from sentry.uptime.grouptype import UptimeDomainCheckFailure, build_detector_fingerprint_component
+from sentry.uptime.issue_platform import create_issue_platform_occurrence
 from sentry.uptime.models import (
     ProjectUptimeSubscription,
     UptimeStatus,

tests/sentry/uptime/test_grouptype.py

@@ -1,11 +1,37 @@
 import pytest
 from jsonschema import ValidationError
 
-from sentry.testutils.cases import TestCase
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
+from sentry.testutils.cases import TestCase, UptimeTestCase
+from sentry.uptime.grouptype import (
+    UptimeDomainCheckFailure,
+    build_detector_fingerprint_component,
+    build_fingerprint,
+)
+from sentry.uptime.models import get_detector
 from sentry.uptime.types import ProjectUptimeSubscriptionMode
 
 
+class BuildDetectorFingerprintComponentTest(UptimeTestCase):
+    def test_build_detector_fingerprint_component(self):
+        project_subscription = self.create_project_uptime_subscription()
+        detector = get_detector(project_subscription.uptime_subscription)
+        assert detector
+
+        fingerprint_component = build_detector_fingerprint_component(detector)
+        assert fingerprint_component == f"uptime-detector:{detector.id}"
+
+
+class BuildFingerprintForProjectSubscriptionTest(UptimeTestCase):
+    def test_build_fingerprint_for_project_subscription(self):
+        project_subscription = self.create_project_uptime_subscription()
+        detector = get_detector(project_subscription.uptime_subscription)
+        assert detector
+
+        fingerprint = build_fingerprint(detector)
+        expected_fingerprint = [build_detector_fingerprint_component(detector)]
+        assert fingerprint == expected_fingerprint
+
+
 class TestUptimeDomainCheckFailureDetectorConfig(TestCase):
     def setUp(self):
         super().setUp()

tests/sentry/uptime/test_issue_platform.py

@@ -9,39 +9,16 @@
 from sentry.models.group import Group, GroupStatus
 from sentry.testutils.cases import UptimeTestCase
 from sentry.testutils.helpers.datetime import freeze_time
-from sentry.uptime.grouptype import UptimeDomainCheckFailure
+from sentry.uptime.grouptype import UptimeDomainCheckFailure, build_detector_fingerprint_component
 from sentry.uptime.issue_platform import (
-    build_detector_fingerprint_component,
     build_event_data_for_occurrence,
-    build_fingerprint,
     build_occurrence_from_result,
     create_issue_platform_occurrence,
     resolve_uptime_issue,
 )
 from sentry.uptime.models import get_detector
 
 
-class BuildDetectorFingerprintComponentTest(UptimeTestCase):
-    def test_build_detector_fingerprint_component(self):
-        project_subscription = self.create_project_uptime_subscription()
-        detector = get_detector(project_subscription.uptime_subscription)
-        assert detector
-
-        fingerprint_component = build_detector_fingerprint_component(detector)
-        assert fingerprint_component == f"uptime-detector:{detector.id}"
-
-
-class BuildFingerprintForProjectSubscriptionTest(UptimeTestCase):
-    def test_build_fingerprint_for_project_subscription(self):
-        project_subscription = self.create_project_uptime_subscription()
-        detector = get_detector(project_subscription.uptime_subscription)
-        assert detector
-
-        fingerprint = build_fingerprint(detector)
-        expected_fingerprint = [build_detector_fingerprint_component(detector)]
-        assert fingerprint == expected_fingerprint
-
-
 @freeze_time()
 class CreateIssuePlatformOccurrenceTest(UptimeTestCase):
     @patch("sentry.uptime.issue_platform.produce_occurrence_to_kafka")