Skip to content

Commit fab4994

Browse files
committed
return the same format & limit 1000 for trace-logs
1 parent 25a696d commit fab4994

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/sentry/api/endpoints/organization_trace_logs.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from sentry.models.organization import Organization
1313
from sentry.models.project import Project
1414
from sentry.organizations.services.organization import RpcOrganization
15-
from sentry.search.events.types import SnubaParams, SnubaRow
15+
from sentry.search.events.types import EventsResponse, SnubaParams
1616
from sentry.snuba import ourlogs
1717
from sentry.snuba.referrer import Referrer
1818
from sentry.utils.validators import INVALID_ID_DETAILS, is_event_id
@@ -56,7 +56,7 @@ def query_logs_data(
5656
orderby: list[str],
5757
offset: int,
5858
limit: int,
59-
) -> list[SnubaRow]:
59+
) -> EventsResponse:
6060
"""Queries log data for a given trace"""
6161
selected_columns = [
6262
"sentry.item_id",
@@ -84,7 +84,7 @@ def query_logs_data(
8484
limit=limit,
8585
referrer=Referrer.API_TRACE_VIEW_LOGS.value,
8686
)
87-
return results["data"]
87+
return results
8888

8989
def get(self, request: Request, organization: Organization) -> HttpResponse:
9090
try:
@@ -104,11 +104,12 @@ def get(self, request: Request, organization: Organization) -> HttpResponse:
104104

105105
update_snuba_params_with_timestamp(request, snuba_params)
106106

107-
def data_fn(offset: int, limit: int) -> list[SnubaRow]:
107+
def data_fn(offset: int, limit: int) -> EventsResponse:
108108
with handle_query_errors():
109109
return self.query_logs_data(snuba_params, trace_ids, orderby, offset, limit)
110110

111111
return self.paginate(
112112
request=request,
113113
paginator=GenericOffsetPaginator(data_fn=data_fn),
114+
max_per_page=1000,
114115
)

0 commit comments

Comments
 (0)