adjust traceViewRef

Author: dashed

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/minimap.tsx

@@ -26,7 +26,6 @@ const TIME_AXIS_HEIGHT = 30;
 const VIEW_HANDLE_HEIGHT = 20;
 
 type PropType = {
-  traceViewRef: React.RefObject<HTMLDivElement>;
   minimapInteractiveRef: React.RefObject<HTMLDivElement>;
   dragProps: DragManagerChildrenProps;
   trace: ParsedTraceType;

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/spanTree.tsx

@@ -23,12 +23,13 @@ type RenderedSpanTree = {
 };
 
 type PropType = {
-  traceViewRef: React.RefObject<HTMLDivElement>;
   trace: ParsedTraceType;
   dragProps: DragManagerChildrenProps;
 };
 
 class SpanTree extends React.Component<PropType> {
+  traceViewRef = React.createRef<HTMLDivElement>();
+
   shouldComponentUpdate(nextProps: PropType) {
     if (nextProps.dragProps.isDragging) {
       return false;
@@ -172,8 +173,8 @@ class SpanTree extends React.Component<PropType> {
       ) : null;
 
     return (
-      <DividerHandlerManager.Provider interactiveLayerRef={this.props.traceViewRef}>
-        <TraceViewContainer innerRef={this.props.traceViewRef}>
+      <DividerHandlerManager.Provider interactiveLayerRef={this.traceViewRef}>
+        <TraceViewContainer innerRef={this.traceViewRef}>
           {spanTree}
           {hiddenSpansMessage}
         </TraceViewContainer>

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/traceView.tsx

@@ -20,35 +20,12 @@ type PropType = {
   event: Readonly<SentryEvent>;
 };
 
-type StateType = {
-  renderMinimap: boolean;
-};
-
-class TraceView extends React.Component<PropType, StateType> {
+class TraceView extends React.Component<PropType> {
   minimapInteractiveRef = React.createRef<HTMLDivElement>();
-  traceViewRef = React.createRef<HTMLDivElement>();
-
-  state: StateType = {
-    renderMinimap: false,
-  };
-
-  componentDidMount() {
-    if (this.traceViewRef.current) {
-      // eslint-disable-next-line react/no-did-mount-set-state
-      this.setState({
-        renderMinimap: true,
-      });
-    }
-  }
 
   renderMinimap = (dragProps: DragManagerChildrenProps, parsedTrace: ParsedTraceType) => {
-    if (!this.state.renderMinimap) {
-      return null;
-    }
-
     return (
       <TraceViewMinimap
-        traceViewRef={this.traceViewRef}
         minimapInteractiveRef={this.minimapInteractiveRef}
         dragProps={dragProps}
         trace={parsedTrace}
@@ -176,11 +153,7 @@ class TraceView extends React.Component<PropType, StateType> {
           return (
             <React.Fragment>
               {this.renderMinimap(dragProps, parsedTrace)}
-              <SpanTree
-                traceViewRef={this.traceViewRef}
-                trace={parsedTrace}
-                dragProps={dragProps}
-              />
+              <SpanTree trace={parsedTrace} dragProps={dragProps} />
             </React.Fragment>
           );
         }}