Skip to content

Commit cbc7b96

Browse files
authored
fix(InstallWizard): Fix exception when InstallWizard completed (#14092)
Since we don't have tests for the submit flow, we did not catch a regression from #13798 where the event handler was not bound to the class instance, causing an `this.setState` is not defined error when submitting the welcome form. This patch fixes the issue. Will add tests to cover this soon after.
1 parent 9dc1ed0 commit cbc7b96

File tree

1 file changed

+3
-6
lines changed
  • src/sentry/static/sentry/app/views

1 file changed

+3
-6
lines changed

src/sentry/static/sentry/app/views/app.jsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,16 +200,13 @@ class App extends React.Component {
200200
e.stopPropagation();
201201
}
202202

203-
onConfigured() {
204-
this.setState({needsUpgrade: false});
205-
}
203+
onConfigured = () => this.setState({needsUpgrade: false});
206204

207-
handleNewsletterConsent = () => {
208-
// this is somewhat hackish
205+
// this is somewhat hackish
206+
handleNewsletterConsent = () =>
209207
this.setState({
210208
newsletterConsentPrompt: false,
211209
});
212-
};
213210

214211
handleGlobalModalClose = () => {
215212
if (!this.mainContainerRef) {

0 commit comments

Comments
 (0)