ref: upgrade to django 5.0 (#64360)

<!-- Describe your PR here. -->

Author: asottile-sentry

requirements-base.txt

@@ -13,7 +13,7 @@ datadog>=0.44
 django-crispy-forms>=1.14.0
 django-csp>=3.7
 django-pg-zero-downtime-migrations>=0.13
-Django>=4.2.8,<5
+Django>=5,<6
 djangorestframework>=3.14.0
 drf-spectacular>=0.26.3
 email-reply-parser>=0.5.12

requirements-dev-frozen.txt

@@ -39,7 +39,7 @@ cssutils==2.9.0
 datadog==0.44.0
 distlib==0.3.4
 distro==1.8.0
-django==4.2.8
+django==5.0.1
 django-crispy-forms==1.14.0
 django-csp==3.7
 django-pg-zero-downtime-migrations==0.13

requirements-frozen.txt

@@ -32,7 +32,7 @@ cssselect==1.0.3
 cssutils==2.9.0
 datadog==0.44.0
 distro==1.8.0
-django==4.2.8
+django==5.0.1
 django-crispy-forms==1.14.0
 django-csp==3.7
 django-pg-zero-downtime-migrations==0.13

src/sentry/auth/providers/saml2/forms.py

@@ -43,7 +43,7 @@ def process_xml(form):
 
 
 class URLMetadataForm(forms.Form):
-    metadata_url = forms.URLField(label="Metadata URL")
+    metadata_url = forms.URLField(label="Metadata URL", assume_scheme="https")
     processor = process_url
 
 
@@ -54,8 +54,8 @@ class XMLMetadataForm(forms.Form):
 
 class SAMLForm(forms.Form):
     entity_id = forms.CharField(label="Entity ID")
-    sso_url = forms.URLField(label="Single Sign On URL")
-    slo_url = forms.URLField(label="Single Log Out URL", required=False)
+    sso_url = forms.URLField(label="Single Sign On URL", assume_scheme="https")
+    slo_url = forms.URLField(label="Single Log Out URL", required=False, assume_scheme="https")
     x509cert = forms.CharField(label="x509 public certificate", widget=forms.Textarea)
     processor = lambda d: d.cleaned_data
 

src/sentry/auth/providers/saml2/onelogin/provider.py

@@ -7,7 +7,7 @@
 
 # Onelogin specifically calls their Metadata URL a 'Issuer URL'
 class OneLoginURLMetadataForm(URLMetadataForm):
-    metadata_url = forms.URLField(label="Issuer URL")
+    metadata_url = forms.URLField(label="Issuer URL", assume_scheme="https")
 
 
 SelectIdP = make_simple_setup(OneLoginURLMetadataForm, "sentry_auth_onelogin/select-idp.html")

src/sentry/new_migrations/monkey/__init__.py

@@ -4,7 +4,7 @@
 from sentry.new_migrations.monkey.executor import SentryMigrationExecutor
 from sentry.new_migrations.monkey.fields import deconstruct
 
-LAST_VERIFIED_DJANGO_VERSION = (4, 2)
+LAST_VERIFIED_DJANGO_VERSION = (5, 0)
 CHECK_MESSAGE = """Looks like you're trying to upgrade Django! Since we monkeypatch
 Django in several places, please verify that we have the latest code, and that the
 monkeypatching still works as expected. Currently the main things to check are:

src/sentry/signals.py

@@ -6,7 +6,7 @@
 from collections.abc import Callable
 from typing import Any
 
-from django.dispatch.dispatcher import NO_RECEIVERS, Signal
+from django.dispatch.dispatcher import Signal
 
 from sentry.utils.env import in_test_environment
 
@@ -79,32 +79,12 @@ def wrapped(func):
             wrapped.__doc__ = receiver.__doc__
         return wrapped(receiver)
 
-    def send_robust(self, sender, **named) -> list[tuple[Receiver, Exception | Any]]:
-        """
-        A reimplementation of send_robust which logs failures, thus recovering stacktraces.
-        """
-        responses: list[tuple[Receiver, Exception | Any]] = []
-        if not self.receivers or self.sender_receivers_cache.get(sender) is NO_RECEIVERS:
-            return responses
-
-        # Call each receiver with whatever arguments it can accept.
-        # Return a list of tuple pairs [(receiver, response), ... ].
-        for receiver in self._live_receivers(sender):
-            try:
-                response = receiver(signal=self, sender=sender, **named)
-            except Exception as err:
-                if in_test_environment():
-                    if (
-                        _receivers_that_raise is _AllReceivers.ALL
-                        or receiver in _receivers_that_raise
-                    ):
-                        raise
-
-                logging.exception("signal.failure", extra={"receiver": repr(receiver)})
-                responses.append((receiver, err))
-            else:
-                responses.append((receiver, response))
-        return responses
+    def _log_robust_failure(self, receiver: object, err: Exception) -> None:
+        if in_test_environment():
+            if _receivers_that_raise is _AllReceivers.ALL or receiver in _receivers_that_raise:
+                raise
+
+        logging.error("signal.failure", extra={"receiver": repr(receiver)}, exc_info=err)
 
 
 buffer_incr_complete = BetterSignal()  # ["model", "columns", "extra", "result"]

src/sentry_plugins/opsgenie/plugin.py

@@ -38,6 +38,7 @@ class OpsGenieOptionsForm(notify.NotificationConfigurationForm):
             attrs={"class": "span6", "placeholder": "e.g. https://api.opsgenie.com/v2/alerts"}
         ),
         help_text="It must be visible to the Sentry server",
+        assume_scheme="https",
         required=True,
     )
 

src/sentry_plugins/redmine/forms.py

@@ -11,7 +11,7 @@
 
 
 class RedmineOptionsForm(forms.Form):
-    host = forms.URLField(help_text=_("e.g. http://bugs.redmine.org"))
+    host = forms.URLField(help_text=_("e.g. http://bugs.redmine.org"), assume_scheme="https")
     key = forms.CharField(
         widget=forms.TextInput(attrs={"class": "span9"}),
         help_text="Your API key is available on your account page after enabling the Rest API (Administration -> Settings -> Authentication)",

tests/sentry/plugins/test_config.py

@@ -11,7 +11,7 @@ class DummyForm(forms.Form):
     textarea = forms.CharField(widget=forms.Textarea, required=False)
     password = forms.CharField(label="A Password", widget=forms.PasswordInput)
     choice = forms.ChoiceField(choices=((1, "one"), (2, "two")))
-    url = forms.URLField()
+    url = forms.URLField(assume_scheme="https")
 
 
 class DummyPlugin(Plugin2):