Skip to content

Commit c3648be

Browse files
authored
ref: Remove unused Group.event_set property (#14036)
Part 3 of #13905
1 parent f4d2114 commit c3648be

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

src/sentry/models/group.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -318,11 +318,6 @@ def qualified_short_id(self):
318318
if self.short_id is not None:
319319
return '%s-%s' % (self.project.slug.upper(), base32_encode(self.short_id), )
320320

321-
@property
322-
def event_set(self):
323-
from sentry.models import Event
324-
return Event.objects.filter(group_id=self.id)
325-
326321
def is_over_resolve_age(self):
327322
resolve_age = self.project.get_option('sentry:resolve_age', None)
328323
if not resolve_age:

tests/integration/tests.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,7 @@ def queue_event(method, url, body, headers):
150150
assert request.call_count is 1
151151
assert Group.objects.count() == 1
152152
group = Group.objects.get()
153-
assert group.event_set.count() == 1
154-
instance = group.event_set.get()
155-
assert instance.data['logentry']['formatted'] == 'foo'
153+
assert group.data['title'] == 'foo'
156154

157155

158156
class SentryRemoteTest(TestCase):

tests/sentry/tasks/test_unmerge.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,6 @@ def create_message_event(template, parameters, environment, release):
435435
events.values()[0],
436436
)
437437

438-
assert source.event_set.count() == 10
439-
440438
assert set(
441439
EventMapping.objects.filter(
442440
group_id=source.id,
@@ -497,8 +495,6 @@ def create_message_event(template, parameters, environment, release):
497495
events.values()[1],
498496
)
499497

500-
assert destination.event_set.count() == 7
501-
502498
assert set(
503499
EventMapping.objects.filter(
504500
group_id=destination.id,

0 commit comments

Comments
 (0)