lint

Author: dashed

src/sentry/static/sentry/app/components/events/interfaces/spans/span_tree.tsx

@@ -6,7 +6,13 @@ import space from 'app/styles/space';
 import Count from 'app/components/count';
 
 import {SpanType, SpanEntry, SentryEvent} from './types';
-import {isValidSpanID, toPercent} from './utils';
+import {
+  isValidSpanID,
+  toPercent,
+  boundsGenerator,
+  SpanBoundsType,
+  SpanGeneratedBoundsType,
+} from './utils';
 import {DragManagerChildrenProps} from './drag_manager';
 import SpanDetail from './span_detail';
 
@@ -656,46 +662,4 @@ const ChevronClosed = props => (
   </svg>
 );
 
-type SpanBoundsType = {startTimestamp: number; endTimestamp: number};
-type SpanGeneratedBoundsType = {start: number; end: number};
-
-const boundsGenerator = (bounds: {
-  traceStartTimestamp: number;
-  traceEndTimestamp: number;
-  viewStart: number; // in [0, 1]
-  viewEnd: number; // in [0, 1]
-}) => {
-  const {traceEndTimestamp, traceStartTimestamp, viewStart, viewEnd} = bounds;
-
-  // viewStart and viewEnd are percentage values (%) of the view window relative to the left
-  // side of the trace view minimap
-
-  // invariant: viewStart <= viewEnd
-
-  // duration of the entire trace in seconds
-  const duration = traceEndTimestamp - traceStartTimestamp;
-
-  const viewStartTimestamp = traceStartTimestamp + viewStart * duration;
-  const viewEndTimestamp = traceEndTimestamp - (1 - viewEnd) * duration;
-  const viewDuration = viewEndTimestamp - viewStartTimestamp;
-
-  return (spanBounds: SpanBoundsType): SpanGeneratedBoundsType => {
-    const {startTimestamp, endTimestamp} = spanBounds;
-
-    const start = (startTimestamp - viewStartTimestamp) / viewDuration;
-
-    if (!_.isNumber(endTimestamp)) {
-      return {
-        start,
-        end: 1,
-      };
-    }
-
-    return {
-      start,
-      end: (endTimestamp - viewStartTimestamp) / viewDuration,
-    };
-  };
-};
-
 export default SpanTree;

src/sentry/static/sentry/app/components/events/interfaces/spans/utils.tsx

@@ -1,4 +1,4 @@
-import {isString} from 'lodash';
+import {isString, isNumber} from 'lodash';
 
 const Rect = (x: number, y: number, width: number, height: number) => {
   // x and y are left/top coords respectively
@@ -64,3 +64,45 @@ export const isValidSpanID = (maybeSpanID: any) => {
 export const toPercent = (value: number) => {
   return `${(value * 100).toFixed(3)}%`;
 };
+
+export type SpanBoundsType = {startTimestamp: number; endTimestamp: number};
+export type SpanGeneratedBoundsType = {start: number; end: number};
+
+export const boundsGenerator = (bounds: {
+  traceStartTimestamp: number;
+  traceEndTimestamp: number;
+  viewStart: number; // in [0, 1]
+  viewEnd: number; // in [0, 1]
+}) => {
+  const {traceEndTimestamp, traceStartTimestamp, viewStart, viewEnd} = bounds;
+
+  // viewStart and viewEnd are percentage values (%) of the view window relative to the left
+  // side of the trace view minimap
+
+  // invariant: viewStart <= viewEnd
+
+  // duration of the entire trace in seconds
+  const duration = traceEndTimestamp - traceStartTimestamp;
+
+  const viewStartTimestamp = traceStartTimestamp + viewStart * duration;
+  const viewEndTimestamp = traceEndTimestamp - (1 - viewEnd) * duration;
+  const viewDuration = viewEndTimestamp - viewStartTimestamp;
+
+  return (spanBounds: SpanBoundsType): SpanGeneratedBoundsType => {
+    const {startTimestamp, endTimestamp} = spanBounds;
+
+    const start = (startTimestamp - viewStartTimestamp) / viewDuration;
+
+    if (!isNumber(endTimestamp)) {
+      return {
+        start,
+        end: 1,
+      };
+    }
+
+    return {
+      start,
+      end: (endTimestamp - viewStartTimestamp) / viewDuration,
+    };
+  };
+};