Skip to content

Commit ab7ea85

Browse files
author
Andrii Soldatenko
committed
fix tests
1 parent 5b2fb68 commit ab7ea85

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

src/sentry/dynamic_sampling/prioritise_projects.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def fetch_projects_with_total_volumes() -> Mapping[int, Sequence[int]]:
2323
while (time.time() - start_time) < MAX_SECONDS:
2424
query = (
2525
Query(
26-
match=Entity(EntityKey.OrgMetricsCounters.value),
26+
match=Entity(EntityKey.GenericMetricsCounters.value),
2727
select=[
2828
Column("org_id"),
2929
Column("project_id"),
@@ -47,10 +47,12 @@ def fetch_projects_with_total_volumes() -> Mapping[int, Sequence[int]]:
4747
.set_limit(CHUNK_SIZE + 1)
4848
.set_offset(offset)
4949
)
50-
request = Request(dataset=Dataset.Metrics.value, app_id="dynamic_sampling", query=query)
50+
request = Request(
51+
dataset=Dataset.PerformanceMetrics.value, app_id="dynamic_sampling", query=query
52+
)
5153
data = raw_snql_query(
5254
request,
53-
referrer="dynamic_sampling.fetch_projects_with_total_volumes",
55+
referrer="dynamic_sampling.fetch_projects_with_count_per_root_total_volumes",
5456
)["data"]
5557
count = len(data)
5658
more_results = count > CHUNK_SIZE

src/sentry/dynamic_sampling/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ def process_projects_sample_rates(org_id, project_ids) -> None:
3434

3535
# Get adjusted sample rate via adjustment model
3636
#
37-
# prioritize_projects.delay(org_id, project_ids)
37+
# prioritise_projects.delay(org_id, project_ids)

src/sentry/snuba/dataset.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ class EntityKey(Enum):
2828
MetricsDistributions = "metrics_distributions"
2929
GenericMetricsDistributions = "generic_metrics_distributions"
3030
GenericMetricsSets = "generic_metrics_sets"
31+
GenericMetricsCounters = "generic_metrics_counters"
3132
IssuePlatform = "search_issues"
Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1+
import pytest
2+
13
from sentry.dynamic_sampling.prioritise_projects import fetch_projects_with_total_volumes
4+
from sentry.testutils.factories import Factories
25

36

7+
@pytest.mark.django_db
48
def test_prioritize_projects():
5-
results = fetch_projects_with_total_volumes()
6-
1 == 1
9+
organization = Factories.create_organization(name="test-org")
10+
Factories.create_project(organization=organization)
11+
fetch_projects_with_total_volumes()

0 commit comments

Comments
 (0)