ref: override _log_robust_failure instead of send_robust

send_robust got way more complicated in django 5.x to handle async signals

Author: asottile-sentry

src/sentry/signals.py

@@ -6,7 +6,7 @@
 from collections.abc import Callable
 from typing import Any
 
-from django.dispatch.dispatcher import NO_RECEIVERS, Signal
+from django.dispatch.dispatcher import Signal
 
 from sentry.utils.env import in_test_environment
 
@@ -79,32 +79,12 @@ def wrapped(func):
             wrapped.__doc__ = receiver.__doc__
         return wrapped(receiver)
 
-    def send_robust(self, sender, **named) -> list[tuple[Receiver, Exception | Any]]:
-        """
-        A reimplementation of send_robust which logs failures, thus recovering stacktraces.
-        """
-        responses: list[tuple[Receiver, Exception | Any]] = []
-        if not self.receivers or self.sender_receivers_cache.get(sender) is NO_RECEIVERS:
-            return responses
-
-        # Call each receiver with whatever arguments it can accept.
-        # Return a list of tuple pairs [(receiver, response), ... ].
-        for receiver in self._live_receivers(sender):
-            try:
-                response = receiver(signal=self, sender=sender, **named)
-            except Exception as err:
-                if in_test_environment():
-                    if (
-                        _receivers_that_raise is _AllReceivers.ALL
-                        or receiver in _receivers_that_raise
-                    ):
-                        raise
-
-                logging.exception("signal.failure", extra={"receiver": repr(receiver)})
-                responses.append((receiver, err))
-            else:
-                responses.append((receiver, response))
-        return responses
+    def _log_robust_failure(self, receiver: object, err: Exception) -> None:
+        if in_test_environment():
+            if _receivers_that_raise is _AllReceivers.ALL or receiver in _receivers_that_raise:
+                raise
+
+        logging.error("signal.failure", extra={"receiver": repr(receiver)}, exc_info=err)
 
 
 buffer_incr_complete = BetterSignal()  # ["model", "columns", "extra", "result"]