Skip to content

Commit 91cf672

Browse files
authored
ref(hybrid-cloud): fix monitor urls using organization_slug (#42825)
1 parent 170f7d4 commit 91cf672

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

src/sentry/api/urls.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -695,18 +695,26 @@
695695
MonitorStatsEndpoint.as_view(),
696696
name="sentry-api-0-monitor-stats",
697697
),
698+
]
699+
),
700+
),
701+
# TODO: include in the /organizations/ route tree + remove old dupes once hybrid cloud launches
702+
url(
703+
r"^organizations/(?P<organization_slug>[^\/]+)/monitors/",
704+
include(
705+
[
698706
url(
699-
r"^(?P<organization_slug>[^\/]+)/(?P<monitor_id>[^\/]+)/$",
707+
r"^(?P<monitor_id>[^\/]+)/$",
700708
MonitorDetailsEndpoint.as_view(),
701709
name="sentry-api-0-monitor-details-with-org",
702710
),
703711
url(
704-
r"^(?P<organization_slug>[^\/]+)/(?P<monitor_id>[^\/]+)/checkins/$",
712+
r"^(?P<monitor_id>[^\/]+)/checkins/$",
705713
MonitorCheckInsEndpoint.as_view(),
706714
name="sentry-api-0-monitor-check-in-index-with-org",
707715
),
708716
url(
709-
r"^(?P<organization_slug>[^\/]+)/(?P<monitor_id>[^\/]+)/stats/$",
717+
r"^(?P<monitor_id>[^\/]+)/stats/$",
710718
MonitorStatsEndpoint.as_view(),
711719
name="sentry-api-0-monitor-stats-with-org",
712720
),

tests/sentry/api/endpoints/test_monitor_checkins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def test_with_dsn_auth_invalid_project(self):
174174

175175
def test_mismatched_org_slugs(self):
176176
monitor = self._create_monitor()
177-
path = f"/api/0/monitors/asdf/{monitor.guid}/checkins/"
177+
path = f"/api/0/organizations/asdf/monitors/{monitor.guid}/checkins/"
178178
self.login_as(user=self.user)
179179

180180
resp = self.client.post(path)

tests/sentry/api/endpoints/test_monitor_details.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_simple(self):
2424

2525
def test_mismatched_org_slugs(self):
2626
monitor = self._create_monitor()
27-
path = f"/api/0/monitors/asdf/{monitor.guid}/"
27+
path = f"/api/0/organizations/asdf/monitors/{monitor.guid}/"
2828
self.login_as(user=self.user)
2929

3030
resp = self.client.get(path)
@@ -230,7 +230,7 @@ def test_cronjob_interval_invalid_inteval(self):
230230

231231
def test_mismatched_org_slugs(self):
232232
monitor = self._create_monitor()
233-
path = f"/api/0/monitors/asdf/{monitor.guid}/"
233+
path = f"/api/0/organizations/asdf/monitors/{monitor.guid}/"
234234
self.login_as(user=self.user)
235235

236236
resp = self.client.put(
@@ -267,7 +267,7 @@ def test_simple(self):
267267

268268
def test_mismatched_org_slugs(self):
269269
monitor = self._create_monitor()
270-
path = f"/api/0/monitors/asdf/{monitor.guid}/"
270+
path = f"/api/0/organizations/asdf/monitors/{monitor.guid}/"
271271
self.login_as(user=self.user)
272272

273273
resp = self.client.delete(path)

0 commit comments

Comments
 (0)