fix moar tests

Author: lynnagara

tests/sentry/api/endpoints/test_group_integration_details.py

@@ -4,30 +4,42 @@
 import mock
 from datetime import timedelta
 from django.utils import timezone
+import copy
 
 from sentry.integrations.example.integration import ExampleIntegration
 from sentry.integrations.exceptions import IntegrationError
 from sentry.models import Activity, ExternalIssue, GroupLink, Integration
 from sentry.testutils import APITestCase
 from sentry.utils.http import absolute_uri
+from sentry.testutils.factories import DEFAULT_EVENT_DATA
 
 
 class GroupIntegrationDetailsTest(APITestCase):
     def setUp(self):
         super(GroupIntegrationDetailsTest, self).setUp()
         self.min_ago = timezone.now() - timedelta(minutes=1)
+        self.event = self.store_event(
+            data={
+                'event_id': 'a' * 32,
+                'timestamp': self.min_ago.isoformat()[:19],
+                'message': 'message',
+                'stacktrace': copy.deepcopy(DEFAULT_EVENT_DATA['stacktrace']),
+            },
+            project_id=self.project.id
+        )
+        self.group = self.event.group
 
     def test_simple_get_link(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=link'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=link'.format(
+            self.group.id, integration.id)
 
         with self.feature('organizations:integrations-issue-basic'):
             response = self.client.get(path)
@@ -67,13 +79,12 @@ def test_simple_get_link(self):
     def test_simple_get_create(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
+        group = self.group
 
         path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
 
@@ -105,7 +116,7 @@ def test_simple_get_create(self):
                         'required': True,
                     }, {
                         'default': ('Sentry Issue: [%s](%s)\n\n```\n'
-                                    'Stacktrace (most recent call last):\n\n  '
+                                    'Stacktrace (most recent call first):\n\n  '
                                     'File "sentry/models/foo.py", line 29, in build_msg\n    '
                                     'string_max_length=self.string_max_length)\n\nmessage\n```'
                                     ) % (group.qualified_short_id, absolute_uri(group.get_absolute_url(params={'referrer': 'example_integration'}))),
@@ -127,15 +138,14 @@ def test_simple_get_create(self):
     def test_get_create_with_error(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(
+            self.group.id, integration.id)
 
         with self.feature('organizations:integrations-issue-basic'):
             with mock.patch.object(ExampleIntegration, 'get_create_issue_config', side_effect=IntegrationError('oops')):
@@ -147,15 +157,14 @@ def test_get_create_with_error(self):
     def test_get_feature_disabled(self):
         self.login_as(user=self.user)
         org = self.organization
-        group = self.create_group()
-        self.create_event(group=group)
         integration = Integration.objects.create(
             provider='example',
             name='Example',
         )
         integration.add_organization(org, self.user)
 
-        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(group.id, integration.id)
+        path = u'/api/0/issues/{}/integrations/{}/?action=create'.format(
+            self.group.id, integration.id)
 
         with self.feature({'organizations:integrations-issue-basic': False}):
             response = self.client.get(path)
@@ -173,7 +182,6 @@ def test_simple_put(self):
         integration.add_organization(org, self.user)
 
         path = u'/api/0/issues/{}/integrations/{}/'.format(group.id, integration.id)
-
         with self.feature('organizations:integrations-issue-basic'):
             response = self.client.put(path, data={
                 'externalIssue': 'APP-123'