♻️ add more tests

Author: michellewzhang

tests/sentry/replays/lib/test_summarize.py

@@ -110,13 +110,6 @@ def _faker() -> Generator[tuple[int, memoryview]]:
 def test_as_log_message() -> None:
     """Basic coverage for events that do not have dedicated test cases yet."""
 
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {"tag": "breadcrumb", "payload": {"category": "ui.click", "message": "div"}},
-    }
-    assert as_log_message(event) is not None
-
     event = {
         "type": 5,
         "timestamp": 0.0,
@@ -155,100 +148,6 @@ def test_as_log_message() -> None:
     }
     assert as_log_message(event) is not None
 
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {
-            "tag": "performanceSpan",
-            "payload": {
-                "op": "navigation.push",
-                "description": "url",
-            },
-        },
-    }
-    assert as_log_message(event) is not None
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {
-            "tag": "breadcrumb",
-            "payload": {"category": "navigation", "data": {"to": "/"}},
-        },
-    }
-    assert as_log_message(event) is None
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {"tag": "breadcrumb", "payload": {"category": "ui.blur"}},
-    }
-    assert as_log_message(event) is None
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {"tag": "breadcrumb", "payload": {"category": "ui.focus"}},
-    }
-    assert as_log_message(event) is None
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {
-            "tag": "performanceSpan",
-            "payload": {
-                "op": "resource.fetch",
-                "description": "https://www.z.com/path?q=true",
-                "endTimestamp": 0.0,
-                "startTimestamp": 0.0,
-                "data": {
-                    "method": "GET",
-                    "statusCode": 404,
-                    "response": {"size": 0},
-                },
-            },
-        },
-    }
-    assert as_log_message(event) is not None
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {
-            "tag": "performanceSpan",
-            "payload": {
-                "op": "resource.fetch",
-                "description": "https://www.z.com/path?q=true",
-                "endTimestamp": 0.0,
-                "startTimestamp": 0.0,
-                "data": {
-                    "method": "GET",
-                    "statusCode": 404,
-                    "response": {"wrong": "wrong"},
-                },
-            },
-        },
-    }
-
-    result = as_log_message(event)
-    assert result is not None
-    assert "unknown" not in result
-
-    event = {
-        "type": 5,
-        "timestamp": 0.0,
-        "data": {
-            "tag": "performanceSpan",
-            "payload": {
-                "op": "web-vital",
-                "description": "largest-contentful-paint",
-                "data": {"size": 0, "rating": "good"},
-            },
-        },
-    }
-    assert as_log_message(event) is not None
-
     event = {
         "type": 5,
         "timestamp": 0.0,
@@ -298,6 +197,70 @@ def test_as_log_message_click() -> None:
     )
 
 
+def test_as_log_message_lcp() -> None:
+    event = (
+        {
+            "type": 5,
+            "timestamp": 1756400489.048,
+            "data": {
+                "tag": "performanceSpan",
+                "payload": {
+                    "op": "web-vital",
+                    "description": "largest-contentful-paint",
+                    "startTimestamp": 1756400489.048,
+                    "endTimestamp": 1756400489.048,
+                    "data": {"value": 623, "size": 623, "rating": "good"},
+                },
+            },
+        },
+    )
+    assert (
+        as_log_message(event)
+        == "Application largest contentful paint: 623 ms and has a good rating at 1756400489048"
+    )
+
+
+def test_as_log_message_navigation() -> None:
+    event = (
+        {
+            "type": 5,
+            "timestamp": 1756400579304,
+            "data": {
+                "tag": "breadcrumb",
+                "payload": {
+                    "timestamp": 1756400579.304,
+                    "type": "default",
+                    "category": "navigation",
+                    "data": {
+                        "from": "https://url-example-previous.com",
+                        "to": "https://url-example.com",
+                    },
+                },
+            },
+        },
+    )
+    assert as_log_message(event) is None
+
+
+def test_as_log_message_feedback() -> None:
+    event = (
+        {
+            "type": 5,
+            "timestamp": 1756400970768,
+            "data": {
+                "tag": "breadcrumb",
+                "payload": {
+                    "timestamp": 1756400970.768,
+                    "type": "default",
+                    "category": "sentry.feedback",
+                    "data": {"feedbackId": "332f05068b2d43e6b5c5557ffecfcd0f"},
+                },
+            },
+        },
+    )
+    assert as_log_message(event) is None
+
+
 def test_as_log_message_invalid_input() -> None:
     assert as_log_message({}) is None
     assert as_log_message({"blah": "wrong"}) is None
@@ -363,6 +326,26 @@ def test_as_log_message_resource_script() -> None:
     assert as_log_message(event) is None
 
 
+def test_as_log_message_navigation_span() -> None:
+    event = (
+        {
+            "type": 5,
+            "timestamp": 1756400579.304,
+            "data": {
+                "tag": "performanceSpan",
+                "payload": {
+                    "op": "navigation.push",
+                    "description": "https://url-example.com",
+                    "startTimestamp": 1756400579.304,
+                    "endTimestamp": 1756400579.304,
+                    "data": {"previous": "https://url-example-prev.com"},
+                },
+            },
+        },
+    )
+    assert as_log_message(event) == "User navigated to: https://url-example.com at 1756400579304"
+
+
 def test_as_log_message_long_console_message() -> None:
     event = {
         "type": 5,