Skip to content

Commit 3fe6709

Browse files
committed
collate z-index
1 parent 950f5bc commit 3fe6709

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/minimap.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
} from './utils';
1717
import {DragManagerChildrenProps} from './dragManager';
1818
import {ParsedTraceType, TickAlignment, SpanType, SpanChildrenLookupType} from './types';
19+
import {zIndex} from './styles';
1920

2021
export const MINIMAP_CONTAINER_HEIGHT = 106;
2122
export const MINIMAP_SPAN_BAR_HEIGHT = 5;
@@ -525,7 +526,7 @@ const MinimapContainer = styled('div')`
525526
position: sticky;
526527
left: 0;
527528
top: 0;
528-
z-index: 99999999999;
529+
z-index: ${zIndex.minimapContainer};
529530
530531
background-color: #fff;
531532

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/spanBar.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
MINIMAP_SPAN_BAR_HEIGHT,
2121
NUM_OF_SPANS_FIT_IN_MINI_MAP,
2222
} from './minimap';
23-
import {SPAN_ROW_HEIGHT, SpanRow} from './styles';
23+
import {SPAN_ROW_HEIGHT, SpanRow, zIndex} from './styles';
2424
import * as DividerHandlerManager from './dividerHandlerManager';
2525
import SpanDetail from './spanDetail';
2626

@@ -663,7 +663,7 @@ export const DividerLine = styled('div')`
663663
transform: translateX(-50%);
664664
665665
background-color: #cdc7d5;
666-
z-index: 999999;
666+
z-index: ${zIndex.dividerLine};
667667
668668
&.hovering {
669669
width: 4px !important;
@@ -723,7 +723,7 @@ const SpanTreeTogglerContainer = styled('div')`
723723
724724
margin-right: 8px;
725725
726-
z-index: 99999;
726+
z-index: ${zIndex.spanTreeToggler};
727727
728728
user-select: none;
729729

src/sentry/static/sentry/app/views/organizationEventsV2/transactionView/styles.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@ import styled from 'react-emotion';
22

33
import space from 'app/styles/space';
44

5+
export const zIndex = {
6+
minimapContainer: 99999999999,
7+
dividerLine: 999999,
8+
spanTreeToggler: 99999,
9+
};
10+
511
export const SPAN_ROW_HEIGHT = 25;
612

713
export const SpanRow = styled('div')`

0 commit comments

Comments
 (0)