move around some page objects + create new ones for reolved issues

Author: billyvg

tests/acceptance/page_objects/base.py

@@ -11,6 +11,9 @@ def __init__(self, browser):
     def driver(self):
         return self.browser.driver
 
+    def wait_until_loaded(self):
+        self.browser.wait_until_not('.loading-indicator')
+
 
 class BaseElement(object):
     def __init__(self, element):

tests/acceptance/page_objects/issue_list.py

@@ -22,5 +22,9 @@ def resolve_issues(self):
         self.browser.click('[aria-label="Resolve"]')
         self.browser.click('[data-test-id="confirm-modal"]')
 
-    def wait_until_loaded(self):
-        self.browser.wait_until_not('.loading-indicator')
+    def wait_for_resolved_issue(self):
+        self.browser.wait_until('[data-test-id="resolved-issue"]')
+
+    def find_resolved_issues(self):
+        self.browser.find_elements_by_css_selector(
+            '[data-test-id="resolved-issue"]')

tests/acceptance/test_organization_group_index.py

@@ -91,10 +91,9 @@ def test_resolve_issues(self, mock_now):
         self.page.select_issue(1)
         self.page.select_issue(2)
         self.page.resolve_issues()
+        self.page.wait_for_resolved_issue()
+        resolved_groups = self.page.find_resolved_issues()
 
-        self.browser.wait_until('[data-test-id="resolved-issue"]')
-        resolved_groups = self.browser.find_elements_by_css_selector(
-            '[data-test-id="resolved-issue"]')
         assert len(resolved_groups) == 2
 
     @patch('django.utils.timezone.now')
@@ -109,8 +108,7 @@ def test_resolve_issues_multi_projects(self, mock_now):
             self.page.select_issue(1)
             self.page.select_issue(2)
             self.page.resolve_issues()
+            self.page.wait_for_resolved_issue()
+            resolved_groups = self.page.find_resolved_issues()
 
-            self.browser.wait_until('[data-test-id="resolved-issue"]')
-            resolved_groups = self.browser.find_elements_by_css_selector(
-                '[data-test-id="resolved-issue"]')
             assert len(resolved_groups) == 2