add more tests

Author: Andrii Soldatenko

tests/sentry/dynamic_sampling/test_prioritise_projects.py

@@ -30,8 +30,23 @@ def test_simple_one_org_one_project(self):
             project_id=p1.id,
             org_id=org1.id,
         )
-        with self.settings(
-            SENTRY_OPTIONS={"dynamic-sampling.prioritise_projects.sample_rate": 1.0}
-        ):
+        with self.options({"dynamic-sampling.prioritise_projects.sample_rate": 1.0}):
             results = fetch_projects_with_total_volumes()
         assert results[org1.id] == [(p1.id, 1.0)]
+
+    def test_simple_one_org_one_project_but_filtered_by_option(self):
+        org1 = self.create_organization("test-org2")
+        p1 = self.create_project(organization=org1)
+
+        self.store_performance_metric(
+            name=TransactionMRI.COUNT_PER_ROOT_PROJECT.value,
+            tags={"transaction": "foo_transaction2"},
+            hours_before_now=1,
+            value=1,
+            project_id=p1.id,
+            org_id=org1.id,
+        )
+        with self.options({"dynamic-sampling.prioritise_projects.sample_rate": 0}):
+            results = fetch_projects_with_total_volumes()
+            # No data because rate is too small
+            assert results[org1.id] == []

tests/sentry/dynamic_sampling/test_tasks.py

@@ -58,9 +58,7 @@ def test_prioritise_projects_simple(self, get_blended_sample_rate):
         proj_c = self.create_project_and_add_metrics("c", 3, test_org)
         proj_d = self.create_project_and_add_metrics("d", 1, test_org)
 
-        with self.settings(
-            SENTRY_OPTIONS={"dynamic-sampling.prioritise_projects.sample_rate": 1.0}
-        ):
+        with self.options({"dynamic-sampling.prioritise_projects.sample_rate": 1.0}):
             with self.feature({"organizations:ds-prioritise-by-project-bias": True}):
                 with self.tasks():
                     prioritise_projects()