Skip to content

Commit 201ceab

Browse files
authored
Merge branch 'master' into feat/feedback-close-message-event
2 parents 5fffdc0 + e2c4b9c commit 201ceab

File tree

20 files changed

+531
-325
lines changed

20 files changed

+531
-325
lines changed

src/sentry/options/defaults.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1704,3 +1704,21 @@
17041704
default=False,
17051705
flags=FLAG_AUTOMATOR_MODIFIABLE,
17061706
)
1707+
1708+
# sample rate for using v2 of deobfuscation that
1709+
# uses function params when line info is missing
1710+
register(
1711+
"profiling.android.deobfuscation_v2_sample_rate",
1712+
default=0.0,
1713+
flags=FLAG_AUTOMATOR_MODIFIABLE,
1714+
)
1715+
1716+
# org IDs that will be using v2 of deobfuscation
1717+
# regardless of the sample rate defined by:
1718+
# "profiling.android.deobfuscation_v2_sample_rate"
1719+
register(
1720+
"profiling.android.deobfuscation_v2_org_ids",
1721+
type=Sequence,
1722+
default=[],
1723+
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE,
1724+
)

static/app/components/globalModal/index.tsx

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ type ModalRenderProps = {
7575
* Closes the modal
7676
*/
7777
closeModal: () => void;
78+
/**
79+
* Reference to the modal's container.
80+
*/
81+
modalContainerRef?: React.RefObject<HTMLDivElement>;
7882
};
7983

8084
/**
@@ -175,14 +179,6 @@ function GlobalModal({onClose}: Props) {
175179
// Close the modal when the browser history changes
176180
useEffect(() => browserHistory.listen(() => actionCloseModal()), []);
177181

178-
const renderedChild = renderer?.({
179-
CloseButton: makeCloseButton(closeModal),
180-
Header: makeClosableHeader(closeModal),
181-
Body: ModalBody,
182-
Footer: ModalFooter,
183-
closeModal,
184-
});
185-
186182
// Default to enabled backdrop
187183
const backdrop = options.backdrop ?? true;
188184

@@ -194,6 +190,15 @@ function GlobalModal({onClose}: Props) {
194190
const clickClose = (e: React.MouseEvent) =>
195191
containerRef.current === e.target && allowBackdropClickClose && closeModal();
196192

193+
const renderedChild = renderer?.({
194+
CloseButton: makeCloseButton(closeModal),
195+
Header: makeClosableHeader(closeModal),
196+
Body: ModalBody,
197+
Footer: ModalFooter,
198+
modalContainerRef: containerRef,
199+
closeModal,
200+
});
201+
197202
return createPortal(
198203
<Fragment>
199204
<Backdrop

static/app/components/group/externalIssuesList.tsx

Lines changed: 0 additions & 268 deletions
This file was deleted.

static/app/components/group/externalIssueActions.spec.tsx renamed to static/app/components/group/externalIssuesList/externalIssueActions.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
userEvent,
66
} from 'sentry-test/reactTestingLibrary';
77

8-
import ExternalIssueActions from 'sentry/components/group/externalIssueActions';
8+
import ExternalIssueActions from 'sentry/components/group/externalIssuesList/externalIssueActions';
99

1010
describe('ExternalIssueActions', function () {
1111
const group = TestStubs.Group();

static/app/components/group/externalIssueActions.tsx renamed to static/app/components/group/externalIssuesList/externalIssueActions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import useApi from 'sentry/utils/useApi';
1313
import useOrganization from 'sentry/utils/useOrganization';
1414
import IntegrationItem from 'sentry/views/settings/organizationIntegrations/integrationItem';
1515

16-
import ExternalIssueForm from './externalIssueForm';
16+
import ExternalIssueForm from '../externalIssueForm';
1717

1818
type Props = {
1919
configurations: GroupIntegration[];

0 commit comments

Comments
 (0)