feat(dynamic-sampling): Add 'Prioritize transaction names' option

Author: priscilawebdev

static/app/types/sampling.tsx

@@ -2,6 +2,7 @@ export enum DynamicSamplingBiasType {
   BOOST_ENVIRONMENTS = 'boostEnvironments',
   BOOST_LATEST_RELEASES = 'boostLatestRelease',
   BOOST_KEY_TRANSACTIONS = 'boostKeyTransactions',
+  BOOST_TRANSACTION_NAMES = 'prioritiseByTxName',
   IGNORE_HEALTH_CHECKS = 'ignoreHealthChecks',
 }
 

static/app/views/settings/project/dynamicSampling/dynamicSampling.spec.tsx

@@ -80,6 +80,11 @@ describe('Dynamic Sampling', function () {
 
     expect(ignoreHealthChecks).toBeEnabled();
     expect(ignoreHealthChecks).toBeChecked();
+
+    // Prioritize transaction names is not available
+    expect(
+      screen.queryByRole('checkbox', {name: 'Prioritize transaction names'})
+    ).not.toBeInTheDocument();
   });
 
   it('renders disabled default UI, when user has not permission to edit', async function () {
@@ -174,4 +179,50 @@ describe('Dynamic Sampling', function () {
       })
     );
   });
+
+  it('render and toggle "Prioritize transaction names" option', function () {
+    const {project, organization} = initializeOrg({
+      ...initializeOrg(),
+      projects: [
+        TestStubs.Project({
+          dynamicSamplingBiases: [
+            ...dynamicSamplingBiases,
+            {id: DynamicSamplingBiasType.BOOST_TRANSACTION_NAMES, active: false},
+          ],
+        }),
+      ],
+      organization: {
+        ...initializeOrg().organization,
+        features: [...ORG_FEATURES, 'dynamic-sampling-transaction-name-priority'],
+      },
+    });
+
+    const mockRequests = renderMockRequests(organization.slug, project.slug);
+
+    render(<DynamicSampling project={project} />, {organization});
+
+    const prioritizeTransactionNames = screen.getByRole('checkbox', {
+      name: 'Prioritize transaction names',
+    });
+
+    expect(prioritizeTransactionNames).toBeEnabled();
+    expect(prioritizeTransactionNames).not.toBeChecked();
+
+    userEvent.click(screen.getByRole('checkbox', {name: 'Prioritize transaction names'}));
+
+    expect(mockRequests.projectDetails).toHaveBeenCalledWith(
+      `/projects/${organization.slug}/${project.slug}/`,
+      expect.objectContaining({
+        data: {
+          dynamicSamplingBiases: [
+            {id: DynamicSamplingBiasType.BOOST_LATEST_RELEASES, active: true},
+            {id: DynamicSamplingBiasType.BOOST_ENVIRONMENTS, active: true},
+            {id: DynamicSamplingBiasType.BOOST_KEY_TRANSACTIONS, active: true},
+            {id: DynamicSamplingBiasType.IGNORE_HEALTH_CHECKS, active: true},
+            {id: DynamicSamplingBiasType.BOOST_TRANSACTION_NAMES, active: true},
+          ],
+        },
+      })
+    );
+  });
 });

static/app/views/settings/project/dynamicSampling/dynamicSampling.tsx

@@ -48,6 +48,10 @@ export const knowDynamicSamplingBiases = {
     label: t('Prioritize key transactions'),
     help: t('Captures more of your most important (starred) transactions'),
   },
+  [DynamicSamplingBiasType.BOOST_TRANSACTION_NAMES]: {
+    label: t('Prioritize transaction names'),
+    help: t("Balance high-volume endpoints so they don't drown out low-volume ones"),
+  },
   [DynamicSamplingBiasType.IGNORE_HEALTH_CHECKS]: {
     label: t('Ignore health checks'),
     help: t('Discards your health checks transactions'),
@@ -58,6 +62,9 @@ export function DynamicSampling({project}: Props) {
   const organization = useOrganization();
   const api = useApi();
 
+  const hasTransactionNamePriorityFlag = organization.features.includes(
+    'dynamic-sampling-transaction-name-priority'
+  );
   const hasAccess = organization.access.includes('project:write');
   const biases = project.dynamicSamplingBiases ?? [];
 
@@ -149,6 +156,14 @@ export function DynamicSampling({project}: Props) {
                 return null;
               }
 
+              // "Prioritize Transaction Names" is only available to orgs with the feature flag
+              if (
+                !hasTransactionNamePriorityFlag &&
+                key === DynamicSamplingBiasType.BOOST_TRANSACTION_NAMES
+              ) {
+                return null;
+              }
+
               return (
                 <BooleanField
                   {...value}