Skip to content

Commit 0c0e0b4

Browse files
authored
fix(alerts): Center table items on alert history page (#45226)
1 parent d7a91df commit 0c0e0b4

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

static/app/views/alerts/list/incidents/index.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,10 @@ function IncidentsListContainer(props: Props) {
315315

316316
const StyledPanelTable = styled(PanelTable)`
317317
font-size: ${p => p.theme.fontSizeMedium};
318+
319+
& > div {
320+
padding: ${space(1.5)} ${space(2)};
321+
}
318322
`;
319323

320324
const StyledAlert = styled(Alert)`

static/app/views/alerts/list/incidents/row.tsx

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,11 @@ function AlertListRow({incident, projectsLoaded, projects, organization}: Props)
4848

4949
return (
5050
<ErrorBoundary>
51-
<Title data-test-id="alert-title">
52-
<Link to={alertLink}>{incident.title}</Link>
53-
</Title>
51+
<FlexCenter>
52+
<Title data-test-id="alert-title">
53+
<Link to={alertLink}>{incident.title}</Link>
54+
</Title>
55+
</FlexCenter>
5456

5557
<NoWrapNumeric>
5658
{getDynamicText({
@@ -66,13 +68,15 @@ function AlertListRow({incident, projectsLoaded, projects, organization}: Props)
6668
)}
6769
</NoWrapNumeric>
6870

69-
<ProjectBadge avatarSize={18} project={!projectsLoaded ? {slug} : project} />
71+
<FlexCenter>
72+
<ProjectBadge avatarSize={18} project={!projectsLoaded ? {slug} : project} />
73+
</FlexCenter>
7074
<NoWrapNumeric>#{incident.id}</NoWrapNumeric>
7175

7276
<FlexCenter>
7377
{teamActor ? (
7478
<Fragment>
75-
<StyledActorAvatar actor={teamActor} size={24} hasTooltip={false} />{' '}
79+
<StyledActorAvatar actor={teamActor} size={18} hasTooltip={false} />{' '}
7680
<TeamWrapper>{teamActor.name}</TeamWrapper>
7781
</Fragment>
7882
) : (
@@ -88,11 +92,6 @@ const Title = styled('div')`
8892
min-width: 130px;
8993
`;
9094

91-
const NoWrapNumeric = styled('div')`
92-
white-space: nowrap;
93-
font-variant-numeric: tabular-nums;
94-
`;
95-
9695
const ProjectBadge = styled(IdBadge)`
9796
flex-shrink: 0;
9897
`;
@@ -101,6 +100,12 @@ const FlexCenter = styled('div')`
101100
${p => p.theme.overflowEllipsis}
102101
display: flex;
103102
align-items: center;
103+
line-height: 1.6;
104+
`;
105+
106+
const NoWrapNumeric = styled(FlexCenter)`
107+
white-space: nowrap;
108+
font-variant-numeric: tabular-nums;
104109
`;
105110

106111
const TeamWrapper = styled('span')`

0 commit comments

Comments
 (0)