This repository was archived by the owner on Nov 7, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add Screenshots automatically. #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
reviewed
Jul 16, 2021
| /// <summary> | ||
| /// Attaches screenshots from the app to events automatically whenever possible. | ||
| /// </summary> | ||
| public bool AttachScreenshots { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably include a note about PII.
There could be potentially private information in the screenshot. For example in bank or chat apps.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotAttachmentContent.cs
Outdated
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotAttachmentContent.cs
Outdated
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotAttachmentContent.cs
Outdated
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotEventProcessor.droid.ios.cs
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotEventProcessor.droid.ios.cs
Outdated
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotEventProcessor.droid.ios.cs
Outdated
Show resolved
Hide resolved
Src/Sentry.Xamarin/Internals/Device/Screenshot/ScreenshotEventProcessor.droid.ios.cs
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Aug 3, 2021
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should release a preview with this
Member
|
@lucas-zimerman no changelog entry? No Danger? :) |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP feature allows adding screenshots to events whenever possible.
new Sentry options:
Goals
* Use of native code so that porting this feature becomes easier to native SDKs.UWP(other platforms doesn't support attaching a screenshot exclusively from the application)Sample Event: https://sentry.io/organizations/sentry-sdks/discover/sentry-xamarin:970c172209f54cf3827b0f3813185764
I suggest the usage of jpeg by default due to the lower performance impact compared to png encoding (see: https://blender.stackexchange.com/questions/148231/what-image-format-encodes-the-fastest-or-at-least-faster-png-is-too-slow)
Challenges