Add feedback associated event id check to setter

tustanivsky · tustanivsky · commit 46d5dc04bc66 · 2025-08-20T16:41:06.000+02:00
diff --git a/plugin-dev/Source/Sentry/Private/Android/AndroidSentryFeedback.cpp b/plugin-dev/Source/Sentry/Private/Android/AndroidSentryFeedback.cpp
@@ -51,6 +51,9 @@ FString FAndroidSentryFeedback::GetContactEmail() const
 
 void FAndroidSentryFeedback::SetAssociatedEvent(const FString& eventId)
 {
+	if (eventId.IsEmpty())
+		return;
+
 	TSharedPtr<FAndroidSentryId> idAndroid = MakeShareable(new FAndroidSentryId(eventId));
 	CallMethod<void>(SetAssociatedEventMethod, idAndroid->GetJObject());
 }
diff --git a/plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentryFeedback.cpp b/plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentryFeedback.cpp
@@ -57,6 +57,9 @@ FString FGenericPlatformSentryFeedback::GetContactEmail() const
 
 void FGenericPlatformSentryFeedback::SetAssociatedEvent(const FString& eventId)
 {
+	if (eventId.IsEmpty())
+		return;
+
 	sentry_value_set_by_key(Feedback, "associated_event_id", sentry_value_new_string(TCHAR_TO_UTF8(*eventId)));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ FString FAndroidSentryFeedback::GetContactEmail() const`
`51`	`51`
`52`	`52`	`void FAndroidSentryFeedback::SetAssociatedEvent(const FString& eventId)`
`53`	`53`	`{`
	`54`	`+ if (eventId.IsEmpty())`
	`55`	`+ return;`
	`56`	`+`
`54`	`57`	`TSharedPtr<FAndroidSentryId> idAndroid = MakeShareable(new FAndroidSentryId(eventId));`
`55`	`58`	`CallMethod<void>(SetAssociatedEventMethod, idAndroid->GetJObject());`
`56`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,9 @@ FString FGenericPlatformSentryFeedback::GetContactEmail() const`
`57`	`57`
`58`	`58`	`void FGenericPlatformSentryFeedback::SetAssociatedEvent(const FString& eventId)`
`59`	`59`	`{`
	`60`	`+ if (eventId.IsEmpty())`
	`61`	`+ return;`
	`62`	`+`
`60`	`63`	`sentry_value_set_by_key(Feedback, "associated_event_id", sentry_value_new_string(TCHAR_TO_UTF8(*eventId)));`
`61`	`64`	`}`
`62`	`65`