chore: minor code cleanup

Author: vaind

.github/workflows/ci.yml

@@ -195,7 +195,7 @@ jobs:
 
       - name: Build WebGL Player
         run: |
-          docker exec -e TEST_DSN=http://publickey@localhost:8000/12345 unity dotnet msbuild /t:UnityConfigureSentryOptions /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
+          docker exec -e TEST_DSN=http://publickey@127.0.0.1:8000/12345 unity dotnet msbuild /t:UnityConfigureSentryOptions /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
           docker exec unity dotnet msbuild /t:UnityBuildPlayerWebGL /p:Configuration=Release /p:OutDir=other src/Sentry.Unity
 
       - name: Upload WebGL Build

scripts/smoke-test-webgl.py

@@ -1,9 +1,9 @@
 #!/usr/bin/env python3
 
 # Testing approach:
-#  1. Start an server that serves the pre-built WebGL app directory (index.html & co), as well as logs API requests
+#  1. Start a web=server for pre-built WebGL app directory (index.html & co) and to collect the API requests
 #  3. Run the smoke test using chromedriver
-#  4. Check the messages received on the API server
+#  4. Check the messages received by the API server
 
 import binascii
 import datetime

src/Sentry.Unity/WebGL/SentryWebGL.cs

@@ -41,7 +41,7 @@ public static void Configure(SentryUnityOptions options)
 
             options.CrashedLastRun = () => false; // no way to recognize crashes in WebGL yet
 
-            // Still cant' find out what's using Threads so:
+            // Still can't find out what's using Threads so:
             options.AutoSessionTracking = false;
             options.DetectStartupTime = StartupTimeDetectionMode.None;
             options.DisableTaskUnobservedTaskExceptionCapture();
@@ -69,7 +69,7 @@ public bool EnqueueEnvelope(Envelope envelope)
             return true;
         }
 
-        public Task FlushAsync(TimeSpan timeout) => Task.CompletedTask; // TODO maybe we can implement this somehow?
+        public Task FlushAsync(TimeSpan timeout) => Task.CompletedTask;
 
         public int QueuedItems { get; }
     }
@@ -146,9 +146,6 @@ private void HandleFailure(HttpResponseMessage response, Envelope processedEnvel
                         processedEnvelope.TryGetEventId(), Encoding.UTF8.GetString(www.uploadHandler.data));
                 }
             }
-
-            // SDK is in debug mode, and envelope was too large. To help troubleshoot:
-            // NOTE: likely no point to do this on WebGL - who would check the file (in IndexDB)?
         }
 
         private UnityWebRequest CreateWebRequest(HttpRequestMessage message)
@@ -198,7 +195,7 @@ internal class UnityWebRequestMessageHandler : HttpMessageHandler
     {
         protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage _, CancellationToken __)
         {
-            // if this throws, see usages of HttpTransport._httpClient
+            // if this throws, see usages of HttpTransport._httpClient - all should be overridden by UnityWebRequestTransport
             throw new InvalidOperationException("UnityWebRequestMessageHandler must be unused");
         }
     }