Merge branch 'master' into lcian/feat/twp

Author: lcian

.github/workflows/danger.yml

@@ -0,0 +1,9 @@
+name: Danger
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, edited, ready_for_review]
+
+jobs:
+  danger:
+    uses: getsentry/github-workflows/.github/workflows/danger.yml@v2

CHANGELOG.md

@@ -2,11 +2,17 @@
 
 ## Unreleased
 
+### Breaking changes
+
+- refactor: remove `debug-logs` feature (#820) by @lcian
+  - The deprecated `debug-logs` feature of the `sentry` crate, used for the SDK's own internal logging, has been removed.
+
 ### Behavioral changes
 
 - feat(core): implement Tracing without Performance (#811) by @lcian
   - The SDK now implements Tracing without Performance, which makes it so that each `Scope` is associated with an object holding some tracing information.
   - This information is used as a fallback when capturing an event with tracing disabled or otherwise no ongoing span, to still allow related events to be linked by a trace.
+  - A new API `Scope::iter_trace_propagation_headers` has been provided that will use the fallback tracing information if there is no current `Span`.
 
 ## 0.38.1
 

Cargo.lock

@@ -22,18 +22,12 @@ harness = false
 [features]
 default = []
 client = ["rand"]
-# I would love to just have a `log` feature, but this is used inside a macro,
-# and macros actually expand features (and extern crate) where they are used!
-debug-logs = ["dep:log"]
 test = ["client", "release-health"]
 release-health = []
 
 [dependencies]
-cadence = { version = "1.4.0", optional = true }
-crc32fast = { version = "1.4.0", optional = true }
 log = { version = "0.4.8", optional = true, features = ["std"] }
 rand = { version = "0.9.0", optional = true }
-regex = { version = "1.7.3", optional = true }
 sentry-types = { version = "0.38.1", path = "../sentry-types" }
 serde = { version = "1.0.104", features = ["derive"] }
 serde_json = { version = "1.0.46" }

sentry-core/Cargo.toml

@@ -95,9 +95,6 @@ functionality.
 - `feature = "test"`: Activates the [`test`] module, which can be used to
   write integration tests. It comes with a test transport which can capture
   all sent events for inspection.
-- `feature = "debug-logs"`: Uses the `log` crate for debug output, instead
-  of printing to `stderr`. This feature is **deprecated** and will be
-  replaced by a dedicated log callback in the future.
 
 [Sentry]: https://sentry.io/
 [`sentry`]: https://crates.io/crates/sentry

sentry-core/README.md

@@ -93,9 +93,6 @@
 //! - `feature = "test"`: Activates the [`test`] module, which can be used to
 //!   write integration tests. It comes with a test transport which can capture
 //!   all sent events for inspection.
-//! - `feature = "debug-logs"`: Uses the `log` crate for debug output, instead
-//!   of printing to `stderr`. This feature is **deprecated** and will be
-//!   replaced by a dedicated log callback in the future.
 //!
 //! [Sentry]: https://sentry.io/
 //! [`sentry`]: https://crates.io/crates/sentry

sentry-core/src/lib.rs

@@ -55,17 +55,12 @@ macro_rules! with_client_impl {
 #[doc(hidden)]
 macro_rules! sentry_debug {
     ($($arg:tt)*) => {
-        #[cfg(feature = "debug-logs")] {
-            ::log::debug!(target: "sentry", $($arg)*);
-        }
-        #[cfg(not(feature = "debug-logs"))] {
-            $crate::Hub::with(|hub| {
-                if hub.client().map_or(false, |c| c.options().debug) {
-                    eprint!("[sentry] ");
-                    eprintln!($($arg)*);
-                }
-            });
-        }
+        $crate::Hub::with(|hub| {
+            if hub.client().map_or(false, |c| c.options().debug) {
+                eprint!("[sentry] ");
+                eprintln!($($arg)*);
+            }
+        });
     }
 }
 

sentry-core/src/macros.rs

@@ -23,7 +23,6 @@ opentelemetry = { version = "0.29.0", default-features = false }
 opentelemetry_sdk = { version = "0.29.0", default-features = false, features = [
     "trace",
 ] }
-opentelemetry-semantic-conventions = "0.29.0"
 
 [dev-dependencies]
 sentry = { path = "../sentry", features = ["test", "opentelemetry"] }

sentry-opentelemetry/Cargo.toml

@@ -47,7 +47,6 @@ tracing = ["sentry-tracing"]
 opentelemetry = ["sentry-opentelemetry"]
 # other features
 test = ["sentry-core/test"]
-debug-logs = ["dep:log", "sentry-core/debug-logs"]
 release-health = ["sentry-core/release-health", "sentry-actix?/release-health"]
 # transports
 transport = ["reqwest", "native-tls"]
@@ -74,7 +73,6 @@ sentry-slog = { version = "0.38.1", path = "../sentry-slog", optional = true }
 sentry-tower = { version = "0.38.1", path = "../sentry-tower", optional = true }
 sentry-tracing = { version = "0.38.1", path = "../sentry-tracing", optional = true }
 sentry-opentelemetry = { version = "0.38.1", path = "../sentry-opentelemetry", optional = true }
-log = { version = "0.4.8", optional = true, features = ["std"] }
 reqwest = { version = "0.12", optional = true, features = [
     "blocking",
     "json",

sentry/Cargo.toml

@@ -76,7 +76,6 @@ extra setup to function properly.
 | `test`            |         |                |            |                                                                                          |
 | `debug-images`    | ✅      | 🔌             |            |                                                                                          |
 | `log`             |         | 🔌             |            | Requires extra setup; See [`sentry-log`]'s documentation.                                |
-| `debug-logs`      |         |                | ❗         | Requires extra setup; See [`sentry-log`]'s documentation.                                |
 | `slog`            |         | 🔌             |            | Requires extra setup; See [`sentry-slog`]'s documentation.                               |
 | `reqwest`         | ✅      |                |            |                                                                                          |
 | `native-tls`      | ✅      |                |            | `reqwest` must be enabled.                                                               |
@@ -110,7 +109,6 @@ extra setup to function properly.
 ### Logging
 - `log`: Enables support for the `log` crate.
 - `slog`: Enables support for the `slog` crate.
-- `debug-logs`: **Deprecated**. Uses the `log` crate for internal logging.
 
 ### Transports
 - `reqwest`: **Default**. Enables the `reqwest` transport.