Add max fail 3 times

Author: sl0thentr0py

sentry-ruby/lib/sentry/transport/http_transport.rb

@@ -69,6 +69,7 @@ def send_data(data)
         raise Sentry::ExternalError, error_info
       end
     rescue SocketError, *HTTP_ERRORS => e
+      on_error if respond_to?(:on_error)
       raise Sentry::ExternalError.new(e&.message)
     end
 

sentry-ruby/lib/sentry/transport/spotlight_transport.rb

@@ -7,16 +7,38 @@ module Sentry
   # Designed to just report events to Spotlight in development.
   class SpotlightTransport < HTTPTransport
     DEFAULT_SIDECAR_URL = "http://localhost:8969/stream"
+    MAX_FAILED_REQUESTS = 3
 
     def initialize(configuration)
       super
       @sidecar_url = configuration.spotlight.is_a?(String) ? configuration.spotlight : DEFAULT_SIDECAR_URL
+      @failed = 0
+      @logged = false
+
+      log_debug("[Spotlight] initialized for url #{@sidecar_url}")
     end
 
     def endpoint
       "/stream"
     end
 
+    def send_data(data)
+      if @failed >= MAX_FAILED_REQUESTS
+        unless @logged
+          log_debug("[Spotlight] disabling because of too many request failures")
+          @logged = true
+        end
+
+        return
+      end
+
+      super
+    end
+
+    def on_error
+      @failed += 1
+    end
+
     # Similar to HTTPTransport connection, but does not support Proxy and SSL
     def conn
       sidecar = URI(@sidecar_url)

sentry-ruby/spec/sentry/transport/spotlight_transport_spec.rb

@@ -15,8 +15,23 @@
     end
   end
 
+  let(:client) { Sentry::Client.new(configuration) }
+  let(:event) { client.event_from_message("foobarbaz") }
+  let(:data) do
+    subject.serialize_envelope(subject.envelope_from_event(event.to_hash)).first
+  end
+
   subject { described_class.new(configuration) }
 
+  it 'logs a debug message during initialization' do
+    string_io = StringIO.new
+    configuration.logger = Logger.new(string_io)
+
+    subject
+
+    expect(string_io.string).to include('sentry: [Spotlight] initialized for url http://localhost:8969/stream')
+  end
+
   describe '#endpoint' do
     it 'returs correct endpoint' do
       expect(subject.endpoint).to eq('/stream')
@@ -39,4 +54,30 @@
       expect(subject.conn.use_ssl?).to eq(false)
     end
   end
+
+  describe '#send_data' do
+    it 'fails a maximum of three times and logs disable once' do
+      string_io = StringIO.new
+      configuration.logger = Logger.new(string_io)
+
+      allow(::Net::HTTP).to receive(:new).and_raise(Errno::ECONNREFUSED)
+
+      3.times do
+        expect do
+          subject.send_data(data)
+        end.to raise_error(Sentry::ExternalError)
+      end
+
+      string_io.string = ""
+      expect(string_io.string).to eq("")
+
+      3.times do
+        expect do
+          subject.send_data(data)
+        end.not_to raise_error
+      end
+
+      expect(string_io.string).to include('sentry: [Spotlight] disabling because of too many request failures')
+    end
+  end
 end