Skip to content

fix(metro): Fixes Metro 0.83.2 breakages #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2025
Merged

fix(metro): Fixes Metro 0.83.2 breakages #5206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04928fd
Fixes baseJSBundle resolution
antonis Sep 25, 2025
2858b27
Fixes bundleToString resolution
antonis Sep 25, 2025
985e404
Temporarily set SENTRY_DISABLE_AUTO_UPLOAD to true
antonis Sep 25, 2025
c094582
Add changelog
antonis Sep 25, 2025
dacc3f9
Revert "Temporarily set SENTRY_DISABLE_AUTO_UPLOAD to true" (#5209)
antonis Sep 25, 2025
850ac0c
Merge branch 'main' into antonis/fix-metro0.83.2-breakage
antonis Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
### Fixes

- Vendor `metro/countLines` function to avoid issues with the private import ([#5185](https://github.com/getsentry/sentry-react-native/pull/5185))
- Fix baseJSBundle and bundleToString TypeErrors with Metro 0.83.2 ([#5206](https://github.com/getsentry/sentry-react-native/pull/5206))

## 7.1.0

Expand Down
28 changes: 20 additions & 8 deletions packages/core/src/js/tools/vendor/metro/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,19 @@ import type * as sourceMapStringType from 'metro/private/DeltaBundler/Serializer
import type * as bundleToStringType from 'metro/private/lib/bundleToString';
import type { MetroSerializer } from '../../utils';

let baseJSBundle: typeof baseJSBundleType;
let baseJSBundleModule: any;
try {
baseJSBundle = require('metro/private/DeltaBundler/Serializers/baseJSBundle');
} catch (e) {
baseJSBundle = require('metro/src/DeltaBundler/Serializers/baseJSBundle');
baseJSBundleModule = require('metro/private/DeltaBundler/Serializers/baseJSBundle');
} catch {
baseJSBundleModule = require('metro/src/DeltaBundler/Serializers/baseJSBundle');
}

const baseJSBundle: typeof baseJSBundleType =
typeof baseJSBundleModule === 'function'
? baseJSBundleModule
: // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
baseJSBundleModule?.baseJSBundle ?? baseJSBundleModule?.default;

let sourceMapString: typeof sourceMapStringType;
try {
// eslint-disable-next-line @typescript-eslint/no-var-requires
Expand All @@ -52,13 +58,19 @@ try {
}
}

let bundleToString: typeof bundleToStringType;
let bundleToStringModule: any;
try {
bundleToString = require('metro/private/lib/bundleToString');
} catch (e) {
bundleToString = require('metro/src/lib/bundleToString');
bundleToStringModule = require('metro/private/lib/bundleToString');
} catch {
bundleToStringModule = require('metro/src/lib/bundleToString');
}

const bundleToString: typeof bundleToStringType =
typeof bundleToStringModule === 'function'
? bundleToStringModule
: // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
bundleToStringModule?.bundleToString ?? bundleToStringModule?.default;

type NewSourceMapStringExport = {
// Since Metro v0.80.10 https://github.com/facebook/metro/compare/v0.80.9...v0.80.10#diff-1b836d1729e527a725305eef0cec22e44605af2700fa413f4c2489ea1a03aebcL28
sourceMapString: typeof sourceMapString;
Expand Down
Loading