Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jan 7, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Revert "chore: update scripts/update-cli.sh to 2.40.0 (#4412)

💡 Motivation and Context

Fixes metrics (new, android) failure

[ 53%] Building CXX object lib/Support/CMakeFiles/hermesSupport.dir/SHA1.cpp.o
In file included from /home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/lib/Support/SHA1.cpp:8:
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/include/hermes/Support/SHA1.h:17:25: error: ‘uint8_t’ was not declared in this scope
   17 | using SHA1 = std::array<uint8_t, SHA1_NUM_BYTES>;
      |                         ^~~~~~~
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/include/hermes/Support/SHA1.h:13:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
[ 53%] Building CXX object lib/CMakeFiles/hermesOptimizer.dir/Optimizer/Scalar/InstructionEscapeAnalysis.cpp.o
[ 56%] Building CXX object lib/CMakeFiles/hermesOptimizer.dir/Optimizer/Scalar/TDZDedup.cpp.o
   12 | #include <string>
  +++ |+#include <cstdint>
   13 | 
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/include/hermes/Support/SHA1.h:17:48: error: template argument 1 is invalid
   17 | using SHA1 = std::array<uint8_t, SHA1_NUM_BYTES>;
      |                                                ^
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/include/hermes/Support/SHA1.h:19:32: error: ‘SHA1’ does not name a type
   19 | std::string hashAsString(const SHA1 &hash);
      |                                ^~~~
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/lib/Support/SHA1.cpp:14:32: error: ‘SHA1’ does not name a type
   14 | std::string hashAsString(const SHA1 &hash) {
      |                                ^~~~
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/lib/Support/SHA1.cpp: In function ‘std::string hermes::hashAsString(const int&)’:
/home/runner/work/sentry-react-native/sentry-react-native/performance-tests/TestAppSentry/node_modules/react-native/sdks/hermes/lib/Support/SHA1.cpp:19:44: error: invalid types ‘const int[unsigned int]’ for array subscript
   19 |     snprintf(buf + (i * 2), 3, "%02x", hash[i]);
      |                                            ^
gmake[3]: *** [lib/Support/CMakeFiles/hermesSupport.dir/build.make:277: lib/Support/CMakeFiles/hermesSupport.dir/SHA1.cpp.o] Error 1

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 464.24 ms 453.04 ms -11.20 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
700cbf4 425.56 ms 436.26 ms 10.70 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
db44eaf 437.65 ms 436.06 ms -1.59 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
8de2810 430.47 ms 428.72 ms -1.75 ms

App size

Revision Plain With Sentry Diff
700cbf4 17.73 MiB 20.07 MiB 2.33 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
db44eaf 17.74 MiB 20.08 MiB 2.35 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
8de2810 17.74 MiB 20.08 MiB 2.34 MiB

@antonis
Copy link
Contributor Author

antonis commented Jan 7, 2025

Closing as the issue persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants