-
-
Notifications
You must be signed in to change notification settings - Fork 354
Add SentrySerialized to ReactNativeWritable convertor, load device context from sentry-java scope #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add SentrySerialized to ReactNativeWritable convertor, load device context from sentry-java scope #3170
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
5b6a0f9
Add SentrySerialized to ReactNativeWritable convertor, load device co…
krystofwoldrich 0baa9de
Update changelog
krystofwoldrich a867f8a
Add RNSentryAndroidTester project to test the RNSentry Android module
krystofwoldrich f1d91dc
Add android CI tests
krystofwoldrich 0a163ea
Add android tests to CI, add basic key value converter tests
krystofwoldrich da1b6a8
Fix emulator working dir
krystofwoldrich 5ed7083
Add tests
krystofwoldrich a864fff
Update devicecontext to use both context and contexts fields
krystofwoldrich 35e8aba
tmp: comment out internal to test android tester ci
krystofwoldrich 65211d0
Update converter for long and other big numbers
krystofwoldrich 74b5094
Fix JS tests JS keeps breadcrumbs on android
krystofwoldrich 48b73f8
Update changelog
krystofwoldrich cc655e3
Revert "tmp: comment out internal to test android tester ci"
krystofwoldrich 9d59cb3
Restore getscope and captureenvelope, lint imports
krystofwoldrich ccf9a79
Merge remote-tracking branch 'origin/main' into kw-android-new-event-…
krystofwoldrich f24552e
Use backticks for tests names
krystofwoldrich 3bb450a
Update cocoa tester name
krystofwoldrich 62c3a72
Add null checks
krystofwoldrich 17cd520
fix changelog
krystofwoldrich f63f2bf
Fix annotations
krystofwoldrich c8564c6
Update Android SDK, fix ts types
krystofwoldrich 583b86c
Rename cocoa context to contexts to unify the naming
krystofwoldrich a8a0713
Add android sdk info
krystofwoldrich 0058ec1
Fix node version for e2e tests
krystofwoldrich 011bbe4
Fix node for newer rn versions
krystofwoldrich cf51653
Fix cocoa tester scheme name
krystofwoldrich 113b6f7
Revert "Use backticks for tests names"
krystofwoldrich 01a4c6f
convert test names to camel case
krystofwoldrich 60f0620
Remove unit tests, we don't have any at the moment
krystofwoldrich 8cc59fa
Merge remote-tracking branch 'origin/main' into kw-android-new-event-…
krystofwoldrich 0b1e855
Add clean emulator step to native android tests
krystofwoldrich b29c3bb
Run clean emulator with emulator running
krystofwoldrich 48d2ba9
Bump Android SDK to 6.27.0
krystofwoldrich e29f4dc
Merge remote-tracking branch 'origin/HEAD' into kw-android-new-event-…
krystofwoldrich fdb07b3
Update changelog
krystofwoldrich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| with: | ||
| access_token: ${{ github.token }} | ||
|
|
||
| test: | ||
| test-ios: | ||
| name: ios | ||
| runs-on: macos-latest | ||
| steps: | ||
|
|
@@ -32,13 +32,13 @@ jobs: | |
| run: yarn install | ||
|
|
||
| - name: Install App Pods | ||
| working-directory: RNSentryTester | ||
| working-directory: RNSentryCocoaTester | ||
| run: pod install | ||
|
|
||
| - name: Run iOS Tests | ||
| working-directory: RNSentryTester | ||
| working-directory: RNSentryCocoaTester | ||
| env: | ||
| SCHEME: RNSentryTester | ||
| SCHEME: RNSentryCocoaTester | ||
| CONFIGURATION: Release | ||
| DESTINATION: 'platform=iOS Simulator,OS=latest,name=iPhone 14' | ||
| run: | | ||
|
|
@@ -47,3 +47,69 @@ jobs: | |
| -scheme $SCHEME -configuration $CONFIGURATION \ | ||
| -destination "$DESTINATION" \ | ||
| test | ||
|
|
||
| test-android: | ||
| name: android | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'adopt' | ||
|
|
||
| - name: Gradle cache | ||
| uses: gradle/gradle-build-action@v2 | ||
|
|
||
| - name: AVD cache | ||
| uses: actions/cache@v3 | ||
| id: avd-cache | ||
| with: | ||
| path: | | ||
| ~/.android/avd/* | ||
| ~/.android/adb* | ||
| key: avd-21 | ||
|
|
||
| - name: Create AVD and generate snapshot for caching | ||
| if: steps.avd-cache.outputs.cache-hit != 'true' | ||
| uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #[email protected] | ||
| with: | ||
| api-level: 21 | ||
| emulator-options: > | ||
| -accel on | ||
| -no-window | ||
| -gpu swiftshader_indirect | ||
| -noaudio | ||
| -no-boot-anim | ||
| -camera-back none | ||
| -camera-front none | ||
| -timezone US/Pacific | ||
| force-avd-creation: false | ||
| disable-animations: true | ||
| arch: x86_64 | ||
| profile: Nexus 6 | ||
| script: echo "Generated AVD snapshot for caching." | ||
|
|
||
| - name: Run connected tests | ||
| uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #[email protected] | ||
| with: | ||
| working-directory: RNSentryAndroidTester | ||
| api-level: 21 | ||
| emulator-options: > | ||
| -no-snapshot-save | ||
| -accel on | ||
| -no-window | ||
| -gpu swiftshader_indirect | ||
| -noaudio | ||
| -no-boot-anim | ||
| -camera-back none | ||
| -camera-front none | ||
| -timezone US/Pacific | ||
| force-avd-creation: false | ||
| disable-animations: true | ||
| arch: x86_64 | ||
| profile: Nexus 6 | ||
| script: | | ||
| ./gradlew uninstallDebug uninstallDebugAndroidTest | ||
| ./gradlew connectedCheck | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| *.iml | ||
krystofwoldrich marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| .gradle | ||
| /local.properties | ||
| /.idea/caches | ||
| /.idea/libraries | ||
| /.idea/modules.xml | ||
| /.idea/workspace.xml | ||
| /.idea/navEditor.xml | ||
| /.idea/assetWizardSettings.xml | ||
| .DS_Store | ||
| /build | ||
| /captures | ||
| .externalNativeBuild | ||
| .cxx | ||
| local.properties | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| plugins { | ||
| id 'com.android.application' | ||
| id 'org.jetbrains.kotlin.android' | ||
| } | ||
|
|
||
| android { | ||
| namespace 'io.sentry.rnsentryandroidtester' | ||
| compileSdk 33 | ||
|
|
||
| defaultConfig { | ||
| applicationId "io.sentry.rnsentryandroidtester" | ||
| minSdk 21 | ||
| targetSdk 33 | ||
| versionCode 1 | ||
| versionName "1.0" | ||
|
|
||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | ||
| } | ||
|
|
||
| buildTypes { | ||
| release { | ||
| minifyEnabled false | ||
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_11 | ||
| targetCompatibility JavaVersion.VERSION_11 | ||
| } | ||
| kotlinOptions { | ||
| jvmTarget = '11' | ||
| } | ||
|
|
||
| testOptions.unitTests.all { | ||
| testLogging { | ||
| events 'passed', 'skipped', 'failed', 'standardOut', 'standardError' | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation project(':RNSentry') | ||
| implementation 'com.facebook.react:react-android:0.72.0' | ||
| implementation 'androidx.core:core-ktx:1.7.0' | ||
| implementation 'androidx.appcompat:appcompat:1.4.1' | ||
| implementation 'com.google.android.material:material:1.5.0' | ||
| testImplementation 'junit:junit:4.13.2' | ||
| androidTestImplementation 'androidx.test.ext:junit:1.1.3' | ||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0' | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.