Skip to content

Commit 99baa55

Browse files
committed
review comments
1 parent 9c5514c commit 99baa55

File tree

1 file changed

+43
-17
lines changed

1 file changed

+43
-17
lines changed

test/touchevents.test.tsx

Lines changed: 43 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -238,29 +238,24 @@ describe('TouchEventBoundary._onTouchStart', () => {
238238
displayName: 'Text',
239239
},
240240
return: {
241-
elementType: {
242-
displayName: 'Text',
241+
memoizedProps: {
242+
'custom-sentry-label-name': 'Connect(View)',
243+
'data-sentry-component': 'MyView',
244+
'data-sentry-element': 'unknown', // should be ignored
245+
'data-sentry-source-file': 'myview.tsx',
243246
},
244247
return: {
245-
memoizedProps: {
246-
'custom-sentry-label-name': 'Connect(View)',
247-
'data-sentry-component': 'MyView',
248-
'data-sentry-element': 'unknown', // should be ignored
249-
'data-sentry-source-file': 'myview.tsx',
248+
elementType: {
249+
displayName: 'Styled(View)',
250250
},
251251
return: {
252-
elementType: {
253-
displayName: 'Styled(View)',
254-
},
255-
return: {
256-
memoizedProps: {
257-
'data-sentry-component': 'Happy',
258-
'data-sentry-element': 'View',
259-
'data-sentry-source-file': 'happyview.js',
260-
},
252+
memoizedProps: {
253+
'data-sentry-component': 'Happy',
254+
'data-sentry-element': 'View',
255+
'data-sentry-source-file': 'happyview.js',
261256
},
262257
},
263-
}
258+
},
264259
},
265260
},
266261
},
@@ -285,4 +280,35 @@ describe('TouchEventBoundary._onTouchStart', () => {
285280
type: defaultProps.breadcrumbType,
286281
});
287282
});
283+
284+
it('deduplicates', () => {
285+
const { defaultProps } = TouchEventBoundary;
286+
const boundary = new TouchEventBoundary(defaultProps);
287+
288+
const event = {
289+
_targetInst: {
290+
elementType: {
291+
displayName: 'Text',
292+
},
293+
return: {
294+
elementType: {
295+
displayName: 'Text',
296+
},
297+
},
298+
},
299+
};
300+
301+
// @ts-expect-error Calling private member
302+
boundary._onTouchStart(event);
303+
304+
expect(addBreadcrumb).toBeCalledWith({
305+
category: defaultProps.breadcrumbCategory,
306+
data: {
307+
path: [{ name: 'Text' }],
308+
},
309+
level: 'info' as SeverityLevel,
310+
message: 'Touch event within element: Text',
311+
type: defaultProps.breadcrumbType,
312+
});
313+
});
288314
});

0 commit comments

Comments
 (0)