Skip to content

Commit 90edad7

Browse files
authored
fix(metro): Unpin Metro 0.83.2 from E2E tests (#5269)
* Revert "fix(e2e): Temporarily pin Metro 0.83.2 for E2E tests (#5234)" This reverts commit bfe454a. * Bump node to 20
1 parent f9c82b5 commit 90edad7

File tree

3 files changed

+2
-64
lines changed

3 files changed

+2
-64
lines changed

.github/workflows/e2e-v2.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
- uses: actions/setup-node@v5
6161
with:
6262
package-manager-cache: false
63-
node-version: 18
63+
node-version: 20
6464
cache: 'yarn'
6565
cache-dependency-path: yarn.lock
6666

@@ -232,7 +232,7 @@ jobs:
232232
- uses: actions/setup-node@v5
233233
with:
234234
package-manager-cache: false
235-
node-version: 18
235+
node-version: 20
236236
cache: 'yarn'
237237
cache-dependency-path: yarn.lock
238238

dev-packages/e2e-tests/cli.mjs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -103,18 +103,6 @@ if (actions.includes('create')) {
103103
env: env,
104104
});
105105

106-
// Only apply the package.json patch for newer RN versions
107-
const versionNumber = parseFloat(RNVersion.replace(/[^\d.]/g, ''));
108-
if (versionNumber >= 0.80) {
109-
execSync(`${patchScriptsDir}/rn.patch.package.json.js --path package.json`, {
110-
stdio: 'inherit',
111-
cwd: appDir,
112-
env: env,
113-
});
114-
} else {
115-
console.log(`Skipping rn.patch.package.json.js for RN ${RNVersion} (< 0.80)`);
116-
}
117-
118106
// Install dependencies
119107
// yalc add doesn't fail if the package is not found - it skips silently.
120108
let yalcAddOutput = execSync(`yalc add @sentry/react-native`, { cwd: appDir, env: env, encoding: 'utf-8' });

dev-packages/e2e-tests/patch-scripts/rn.patch.package.json.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)