Skip to content

Commit 41f816a

Browse files
authored
Merge branch 'main' into feat/replay
2 parents 60d07df + fada0cd commit 41f816a

File tree

7 files changed

+71
-31
lines changed

7 files changed

+71
-31
lines changed

CHANGELOG.md

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,21 @@ Access to Mobile Replay is limited to early access orgs on Sentry. If you're int
5050
- Bump CLI from v2.30.4 to v2.31.2 ([#3719](https://github.com/getsentry/sentry-react-native/pull/3719))
5151
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2312)
5252
- [diff](https://github.com/getsentry/sentry-cli/compare/2.30.4...2.31.2)
53-
- Bump Cocoa SDK from v8.25.0 to v8.25.2 ([#3802](https://github.com/getsentry/sentry-react-native/pull/3802))
54-
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8252)
55-
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.25.0...8.25.2)
53+
- Bump Cocoa SDK from v8.26.0 to v8.27.0 ([#3858](https://github.com/getsentry/sentry-react-native/pull/3858))
54+
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8270)
55+
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.26.0...8.27.0)
56+
57+
## 5.22.3
58+
59+
### Fixes
60+
61+
- Missing `RNSentryOnDrawReporterView` on iOS ([#3832](https://github.com/getsentry/sentry-react-native/pull/3832))
62+
63+
### Dependencies
64+
65+
- Bump Cocoa SDK from v8.25.0 to v8.26.0 ([#3802](https://github.com/getsentry/sentry-react-native/pull/3802), [#3815](https://github.com/getsentry/sentry-react-native/pull/3815))
66+
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8260)
67+
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.25.0...8.26.0)
5668

5769
## 5.22.2
5870

CONTRIBUTING.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ Comment out sentry dependency in `RNSentry.podspec`.
113113

114114
```diff
115115
- s.dependency 'Sentry/HybridSDK', '7.31.0'
116-
+ # s.dependency 'Sentry/HybridSDK', '7.31.0'
116+
+ s.dependency 'Sentry/HybridSDK'
117117
```
118118

119119
Add local pods to `sample/ios/Podfile`.
@@ -123,9 +123,7 @@ target 'sample' do
123123

124124
# ... react native config
125125

126-
+ pod 'Sentry/HybridSDK', :path => '../../../sentry-cocoa'
127-
+ pod 'SentryPrivate', :path => '../../../sentry-cocoa/SentryPrivate.podspec'
128-
126+
pod 'Sentry/HybridSDK', :path => '../../../../sentry-cocoa'
129127
# ... rest of the configuration
130128

131129
end
@@ -151,12 +149,12 @@ cd sentry-react-native/sample
151149

152150
Add local maven to `sample/android/build.gradle`.
153151

154-
```diff
155-
+ allprojects {
156-
+ repositories {
157-
+ mavenLocal()
158-
+ }
159-
+ }
152+
```gradle
153+
allprojects {
154+
repositories {
155+
mavenLocal()
156+
}
157+
}
160158
```
161159

162160
Update `sentry-android` version, to the one locally published, in `android/build.gradle`.

RNSentry.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Pod::Spec.new do |s|
3333
s.preserve_paths = '*.js'
3434

3535
s.dependency 'React-Core'
36-
s.dependency 'Sentry/HybridSDK', '8.25.0-alpha.0'
36+
s.dependency 'Sentry/HybridSDK', '8.27.0'
3737

3838
s.source_files = 'ios/**/*.{h,m,mm}'
3939
s.public_header_files = 'ios/RNSentry.h'

RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10+
33958C692BFCF12600AD1FB6 /* RNSentryOnDrawReporterTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 33958C682BFCF12600AD1FB6 /* RNSentryOnDrawReporterTests.m */; };
1011
33AFDFED2B8D14B300AAB120 /* RNSentryFramesTrackerListenerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 33AFDFEC2B8D14B300AAB120 /* RNSentryFramesTrackerListenerTests.m */; };
1112
33AFDFF12B8D15E500AAB120 /* RNSentryDependencyContainerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 33AFDFF02B8D15E500AAB120 /* RNSentryDependencyContainerTests.m */; };
1213
33F58AD02977037D008F60EA /* RNSentryTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 33F58ACF2977037D008F60EA /* RNSentryTests.mm */; };
@@ -17,6 +18,8 @@
1718
1482D5685A340AB93348A43D /* Pods-RNSentryCocoaTesterTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RNSentryCocoaTesterTests.release.xcconfig"; path = "Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests.release.xcconfig"; sourceTree = "<group>"; };
1819
3360898D29524164007C7730 /* RNSentryCocoaTesterTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = RNSentryCocoaTesterTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
1920
338739072A7D7D2800950DDD /* RNSentryTests.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RNSentryTests.h; sourceTree = "<group>"; };
21+
33958C672BFCEF5A00AD1FB6 /* RNSentryOnDrawReporter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = RNSentryOnDrawReporter.h; path = ../ios/RNSentryOnDrawReporter.h; sourceTree = "<group>"; };
22+
33958C682BFCF12600AD1FB6 /* RNSentryOnDrawReporterTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RNSentryOnDrawReporterTests.m; sourceTree = "<group>"; };
2023
33AFDFEC2B8D14B300AAB120 /* RNSentryFramesTrackerListenerTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RNSentryFramesTrackerListenerTests.m; sourceTree = "<group>"; };
2124
33AFDFEE2B8D14C200AAB120 /* RNSentryFramesTrackerListenerTests.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RNSentryFramesTrackerListenerTests.h; sourceTree = "<group>"; };
2225
33AFDFF02B8D15E500AAB120 /* RNSentryDependencyContainerTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RNSentryDependencyContainerTests.m; sourceTree = "<group>"; };
@@ -76,13 +79,15 @@
7679
33AFDFEE2B8D14C200AAB120 /* RNSentryFramesTrackerListenerTests.h */,
7780
33AFDFF02B8D15E500AAB120 /* RNSentryDependencyContainerTests.m */,
7881
33AFDFF22B8D15F600AAB120 /* RNSentryDependencyContainerTests.h */,
82+
33958C682BFCF12600AD1FB6 /* RNSentryOnDrawReporterTests.m */,
7983
);
8084
path = RNSentryCocoaTesterTests;
8185
sourceTree = "<group>";
8286
};
8387
33AFE0122B8F319000AAB120 /* RNSentry */ = {
8488
isa = PBXGroup;
8589
children = (
90+
33958C672BFCEF5A00AD1FB6 /* RNSentryOnDrawReporter.h */,
8691
33AFE0132B8F31AF00AAB120 /* RNSentryDependencyContainer.h */,
8792
);
8893
name = RNSentry;
@@ -198,6 +203,7 @@
198203
files = (
199204
33AFDFF12B8D15E500AAB120 /* RNSentryDependencyContainerTests.m in Sources */,
200205
33F58AD02977037D008F60EA /* RNSentryTests.mm in Sources */,
206+
33958C692BFCF12600AD1FB6 /* RNSentryOnDrawReporterTests.m in Sources */,
201207
33AFDFED2B8D14B300AAB120 /* RNSentryFramesTrackerListenerTests.m in Sources */,
202208
);
203209
runOnlyForDeploymentPostprocessing = 0;
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
#import <XCTest/XCTest.h>
2+
#import "RNSentryOnDrawReporter.h"
3+
4+
@interface RNSentryOnDrawReporterTests : XCTestCase
5+
6+
@end
7+
8+
@implementation RNSentryOnDrawReporterTests
9+
10+
- (void)testRNSentryOnDrawReporterViewIsAvailableWhenUIKitIs
11+
{
12+
RNSentryOnDrawReporterView* view = [[RNSentryOnDrawReporterView alloc] init];
13+
XCTAssertNotNil(view);
14+
}
15+
16+
@end

ios/RNSentryOnDrawReporter.h

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
#import <Sentry/SentryDefines.h>
2+
3+
#if SENTRY_HAS_UIKIT
4+
5+
#import <UIKit/UIKit.h>
6+
#import <React/RCTViewManager.h>
7+
#import "RNSentryFramesTrackerListener.h"
8+
9+
@interface RNSentryOnDrawReporter : RCTViewManager
10+
11+
@end
12+
13+
@interface RNSentryOnDrawReporterView : UIView
14+
15+
@property (nonatomic, strong) RNSentryFramesTrackerListener* framesListener;
16+
@property (nonatomic, copy) RCTBubblingEventBlock onDrawNextFrame;
17+
@property (nonatomic) bool fullDisplay;
18+
@property (nonatomic) bool initialDisplay;
19+
@property (nonatomic, weak) RNSentryOnDrawReporter* delegate;
20+
21+
@end
22+
23+
#endif

ios/RNSentryOnDrawReporter.m

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,9 @@
1+
#import "RNSentryOnDrawReporter.h"
2+
13
#if SENTRY_HAS_UIKIT
24

3-
#import <UIKit/UIKit.h>
4-
#import <React/RCTViewManager.h>
5-
#import "RNSentryFramesTrackerListener.h"
65
#import <Sentry/SentryDependencyContainer.h>
76

8-
@interface RNSentryOnDrawReporter : RCTViewManager
9-
10-
@end
11-
12-
@interface RNSentryOnDrawReporterView : UIView
13-
14-
@property (nonatomic, strong) RNSentryFramesTrackerListener* framesListener;
15-
@property (nonatomic, copy) RCTBubblingEventBlock onDrawNextFrame;
16-
@property (nonatomic) bool fullDisplay;
17-
@property (nonatomic) bool initialDisplay;
18-
@property (nonatomic, weak) RNSentryOnDrawReporter* delegate;
19-
20-
@end
21-
227
@implementation RNSentryOnDrawReporter
238

249
RCT_EXPORT_MODULE(RNSentryOnDrawReporter)

0 commit comments

Comments
 (0)