Merge fa4025a into 9cab16b

Author: antonis

CHANGELOG.md

@@ -12,6 +12,7 @@
 
 - Skips ignoring require cycle logs for RN 0.70 or newer ([#4214](https://github.com/getsentry/sentry-react-native/pull/4214))
 - Enhanced accuracy of time-to-display spans. ([#4189](https://github.com/getsentry/sentry-react-native/pull/4189))
+- Speed up getBinaryImages for finishing transactions and capturing events ([#4194](https://github.com/getsentry/sentry-react-native/pull/4194))
 
 ### Features
 

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.mm

@@ -295,7 +295,7 @@ - (void)prepareNativeFrameMocksWithLocalSymbolication: (BOOL) debug
   OCMStub([sentryDebugImageMock serialize]).andReturn(serializedDebugImage);
 
   id sentryDebugImageProviderMock = OCMClassMock([SentryDebugImageProvider class]);
-  OCMStub([sentryDebugImageProviderMock getDebugImagesForAddresses:[NSSet setWithObject:@"0x000000000001b669"] isCrash:false]).andReturn(@[sentryDebugImageMock]);
+  OCMStub([sentryDebugImageProviderMock getDebugImagesForImageAddressesFromCache:[NSSet setWithObject:@"0x000000000001b669"]]).andReturn(@[sentryDebugImageMock]);
 
   OCMStub([sentryDependencyContainerMock debugImageProvider]).andReturn(sentryDebugImageProviderMock);
 }

packages/core/ios/RNSentry.h

@@ -14,7 +14,7 @@
 typedef int (*SymbolicateCallbackType)(const void *, Dl_info *);
 
 @interface SentryDebugImageProvider ()
-- (NSArray<SentryDebugMeta *> * _Nonnull)getDebugImagesForAddresses:(NSSet<NSString *> * _Nonnull)addresses isCrash:(BOOL)isCrash;
+- (NSArray<SentryDebugMeta *> * _Nonnull)getDebugImagesForImageAddressesFromCache:(NSSet<NSString *> * _Nonnull)addresses;
 @end
 
 @interface

packages/core/ios/RNSentry.mm

@@ -340,7 +340,7 @@ - (NSDictionary*) fetchNativeStackFramesBy: (NSArray<NSNumber*>*)instructionsAdd
   } else {
     NSMutableArray<NSDictionary<NSString *, id> *> * _Nonnull serializedDebugMetaImages = [[NSMutableArray alloc] init];
 
-    NSArray<SentryDebugMeta *> *debugMetaImages = [[[SentryDependencyContainer sharedInstance] debugImageProvider] getDebugImagesForAddresses:imagesAddrToRetrieveDebugMetaImages isCrash:false];
+    NSArray<SentryDebugMeta *> *debugMetaImages = [[[SentryDependencyContainer sharedInstance] debugImageProvider] getDebugImagesForImageAddressesFromCache:imagesAddrToRetrieveDebugMetaImages];
 
     for (SentryDebugMeta *debugImage in debugMetaImages) {
       [serializedDebugMetaImages addObject:[debugImage serialize]];